aboutsummaryrefslogtreecommitdiff
path: root/src
Commit message (Collapse)AuthorAge
* ExecAgg() failed to finish running out set-returning functions in the lastTom Lane2009-06-17
| | | | | | aggregated tuple of a run. Per report from Laurenz Albe. This is a new bug in 8.4, but only because prior versions rejected SRFs in an Agg plan node altogether.
* Fix typo in error message: tgargv -> tg_argvPeter Eisentraut2009-06-17
|
* Change test tables in copy2 regression test to be temporary tables.Tom Lane2009-06-14
| | | | | | | | | This prevents autovacuum from reclaiming free space in them and causing the test's output row order to change, which is causing intermittent bogus failure reports in the buildfarm. Backpatch to 8.3. The issue exists further back, but since autovacuum was not on by default before 8.3, it's not a problem for buildfarm testing.
* Fix get_sort_group_operators() so that it doesn't think arrays can be groupedTom Lane2009-06-13
| | | | | via hashing. Eventually we ought to make that possible, but it won't happen for 8.4. Per yesterday's report from Robert Haas.
* Tweak the display of incoming foreign-key constraints in \d, per discussionPeter Eisentraut2009-06-13
| | | | | on hackers. Also, take that string out of the translation roster, since it's now entirely pseudo-SQL.
* Fix several places where a function was declared static and then definedTom Lane2009-06-12
| | | | without static. Per testing with a compiler that complains about this.
* time to tag rc1 ...REL8_4_RC1Marc G. Fournier2009-06-12
|
* Tighten typedef check for Linux.Bruce Momjian2009-06-12
|
* Mention BSD/OS find_typedef behavior.Bruce Momjian2009-06-12
|
* Document struct/union problem with pgindent.Bruce Momjian2009-06-11
|
* Revisit AlterTableCreateToastTable's API once again, hoping to make it whatTom Lane2009-06-11
| | | | | pg_migrator actually needs and not just a partial solution. We have to be able to specify the OID that the new toast table should be created with.
* Remove our inadequate kluge that tried to get AIX's various broken versionsTom Lane2009-06-11
| | | | | of getaddrinfo() to work. Instead, recommend updating the OS to get a working version of getaddrinfo. Per recent discussions.
* Update time zone data files to tzdata release 2009i: DST law changes inTom Lane2009-06-11
| | | | Bangladesh, Egypt, Jordan, Pakistan.
* Fix things so that you can still do "select foo()" where foo is a SQLTom Lane2009-06-11
| | | | | | | function returning setof record. This used to work, more or less accidentally, but I had broken it while extending the code to allow materialize-mode functions to be called in select lists. Add a regression test case so it doesn't get broken again. Per gripe from Greg Davidson.
* Somebody seems to have thought they could get away without checking forTom Lane2009-06-11
| | | | | | rsinfo->expectedDesc == NULL in deflist_to_tuplestore(), but that doesn't look very safe to me. Noted in passing while studying problem report from Greg Davidson.
* 8.4 pgindent run, with new combined Linux/FreeBSD/MinGW typedef listBruce Momjian2009-06-11
| | | | provided by Andrew.
* Add FreeBSD support for find_typedef, per request from Andrew.Bruce Momjian2009-06-11
|
* Translation updatesPeter Eisentraut2009-06-10
|
* Arrange that the string "syntax error" generated by bison is translated.Peter Eisentraut2009-06-10
|
* Clarify to the translator that plpgsql_yyerror() deals with the translationPeter Eisentraut2009-06-10
| | | | | | | of "syntax error", not the literal string. This same change was made in the backend a while ago; but it applies to plpgsql as well.
* Clarify error messagePeter Eisentraut2009-06-10
|
* Improve capitalization and punctuation in recently added GiST message.Peter Eisentraut2009-06-10
|
* Keep rs_startblock the same during heap_rescan, so that a rescan of a SeqScanTom Lane2009-06-10
| | | | | | | | | | | | | | node starts from the same place as the first scan did. This avoids surprising behavior of scrollable and WITH HOLD cursors, as seen in Mark Kirkwood's bug report of yesterday. It's not entirely clear whether a rescan should be forced to drop out of the syncscan mode, but for the moment I left the code behaving the same on that point. Any change there would only be a performance and not a correctness issue, anyway. Back-patch to 8.3, since the unstable behavior was created by the syncscan patch.
* Fix cash_in() to behave properly in locales where frac_digits is zero,Tom Lane2009-06-10
| | | | | | | eg Japan. Report and fix by Itagaki Takahiro. Also fix CASHDEBUG printout format for branches with 64-bit money type, and some minor comment cleanup. Back-patch to 7.4, because it's broken all the way back.
* Fix Linux typedef code.Bruce Momjian2009-06-10
|
* Correct/improve the datetime_precision field in the information schema.Peter Eisentraut2009-06-10
| | | | | | | | | | In particular, always show 0 for the date type instead of null, and show 6 (the default) for time, timestamp, and interval without a declared precision. This is now in fuller conformance with the SQL standard. Also clarify the documentation about this. discovered and analyzed by Konstantin Izmailov and Tom Lane
* Make handling of INTERVAL DAY TO MINUTE and INTERVAL DAY TO SECOND inputTom Lane2009-06-10
| | | | | | | | | | | | more consistent with other cases, by having an unlabeled integer field be treated as a number of minutes or seconds respectively. These cases are outside the spec (which insists on full "dd hh:mm" or "dd hh:mm:ss" input respectively), so it's not much help to us in deciding what to do. But with this change, it's uniformly the case that an unlabeled integer will be considered as being a number of the interval's rightmost field. The change also takes us back to the 8.3 behavior of throwing error for certain ambiguous inputs such as INTERVAL '1 2' DAY TO MINUTE. Per recent discussion.
* Ensure xmlFree(NULL) is a no-op instead of a core dump. Per report fromTom Lane2009-06-10
| | | | | | | | | Sergey Burladyan, there are at least some dank corners of libxml2 that assume this behavior, even though their published documentation suggests they shouldn't. This is only really a live problem in 8.3, but the code is still there for possible debugging use in HEAD, so patch both branches.
* Fix BSD find_typedef logic.Bruce Momjian2009-06-10
|
* Update pgindent instructions.Bruce Momjian2009-06-10
|
* Document new location for typedef list.Bruce Momjian2009-06-10
|
* Fix xmlattribute escaping XML special characters twice (bug #4822).Peter Eisentraut2009-06-09
| | | | Author: Itagaki Takahiro <itagaki.takahiro@oss.ntt.co.jp>
* Mark internal_in as not strict, so that the construct "null::internal"Tom Lane2009-06-09
| | | | | | | | | | | | | | | | | | | | will throw an error, rather than possibly allowing someone to synthesize a manual call to an internal-accepting function. As of CVS HEAD and existing releases, all such functions are either STRICT or careful about null inputs, so there is no current security issue here. But it seems like a good idea to lock this down to protect against future mistakes. In passing, similarly lock down trigger_in, language_handler_in, opaque_in, and shell_in. These are not believed to present any security risk, but there's still no good reason to allow nulls of these types to be created. I left the polymorphic pseudotypes (anyelement etc) alone, since a null of one of those types doesn't seem to be a problem --- the worst you can say about it is that it doesn't have an underlying non-polymorphic type. If we were to make this change during normal development, we'd just automatically bump catversion for a pg_proc.h change. But since this doesn't create a compatibility risk and isn't believed to be fixing a live bug, it seems better not to force a catversion bump in late beta.
* Fix typo, per TomAlvaro Herrera2009-06-09
|
* Switch order of tests to avoid possible Assert failure forTom Lane2009-06-09
| | | | | | "array_agg_finalfn(null)". We should modify pg_proc entries to prevent this query from being accepted, but let's just make the function itself secure too. Per my note of today.
* Dynamically set a lower bound on autovacuum nap time so that we don't rebuildAlvaro Herrera2009-06-09
| | | | | | | the database list too often. Per bug report from Łukasz Jagiełło and ensuing discussion on pgsql-performance.
* Fix failure to double-quote function argument names when needed, inTom Lane2009-06-09
| | | | | pg_get_function_arguments() and related functions. Per report from Andreas Nolte.
* Fix map_sql_table_to_xmlschema() with dropped attributes.Peter Eisentraut2009-06-08
| | | | also backpatched to 8.3
* Improve the IndexVacuumInfo/IndexBulkDeleteResult API to allow somewhat saneTom Lane2009-06-06
| | | | | | | | | | | | | | | | | | | behavior in cases where we don't know the heap tuple count accurately; in particular partial vacuum, but this also makes the API a bit more useful for ANALYZE. This patch adds "estimated_count" flags to both structs so that an approximate count can be flagged as such, and adjusts the logic so that approximate counts are not used for updating pg_class.reltuples. This fixes my previous complaint that VACUUM was putting ridiculous values into pg_class.reltuples for indexes. The actual impact of that bug is limited, because the planner only pays attention to reltuples for an index if the index is partial; which probably explains why beta testers hadn't noticed a degradation in plan quality from it. But it needs to be fixed. The whole thing is a bit messy and should be redesigned in future, because reltuples now has the potential to drift quite far away from reality when a long period elapses with no non-partial vacuums. But this is as good as it's going to get for 8.4.
* Move variable declaration to avoid 'unused variable' warning when theTom Lane2009-06-06
| | | | ifdef doesn't trigger. Not worth back-patching. Per buildfarm reports.
* Fix a serious bug introduced into GIN in 8.4: now that MergeItemPointers()Tom Lane2009-06-06
| | | | | | | | | is supposed to remove duplicate heap TIDs, we have to be sure to reduce the tuple size and posting-item count accordingly in addItemPointersToTuple(). Failing to do so resulted in the effective injection of garbage TIDs into the index contents, ie, whatever happened to be in the memory palloc'd for the new tuple. I'm not sure that this fully explains the index corruption reported by Tatsuo Ishii, but the test case I'm using no longer fails.
* Adjust recent PERL_SYS_INIT3 call to avoid platforms where it might fail, ↵Andrew Dunstan2009-06-05
| | | | and to remove compilation warning. Backpatch the release 7.4
* GIN's ItemPointerIsMin, ItemPointerIsMax, and ItemPointerIsLossyPage macrosTom Lane2009-06-05
| | | | | | | | | | | | should use GinItemPointerGetBlockNumber/GinItemPointerGetOffsetNumber, not ItemPointerGetBlockNumber/ItemPointerGetOffsetNumber, because the latter will Assert() on ip_posid == 0, ie a "Min" pointer. (Thus, ItemPointerIsMin has never worked at all, but it seems unused at present.) I'm not certain that the case can occur in normal functioning, but it's blowing up on me while investigating Tatsuo-san's data corruption problem. In any case it seems like a problem waiting to bite someone. Back-patch just in case this really is a problem for somebody in the field.
* Search for versioned perl library instead of using hardcoded name on ↵Andrew Dunstan2009-06-05
| | | | Windows. Backpatch to release 8.3
* Trivial code style cleanup around a couple of ngettext calls.Tom Lane2009-06-04
|
* Remove a couple of debugging messages that have been #ifdef'd out for ages.Tom Lane2009-06-04
| | | | | Seems silly to ask translators to expend work on these, especially in pluralized variants.
* Improve the recently-added support for properly pluralized error messagesTom Lane2009-06-04
| | | | | | | | | | by extending the ereport() API to cater for pluralization directly. This is better than the original method of calling ngettext outside the elog.c code because (1) it avoids double translation, which wastes cycles and in the worst case could give a wrong result; and (2) it avoids having to use a different coding method in PL code than in the core backend. The client-side uses of ngettext are not touched since neither of these concerns is very pressing in the client environment. Per my proposal of yesterday.
* Initialise perl library as documented in perl API. Backpatch to release 7.4.Andrew Dunstan2009-06-04
|
* Clean up ecpg's use of mmerror(): const-ify the format argument, add anTom Lane2009-06-03
| | | | | | __attribute__() marker so that gcc can validate the format string against the actual arguments, get rid of overcomplicated and unsafe usage in base_yyerror().
* Fix tsquerysel() to not fail on an empty TSQuery. Per report fromTom Lane2009-06-03
| | | | Tatsuo Ishii.