aboutsummaryrefslogtreecommitdiff
path: root/src
Commit message (Collapse)AuthorAge
* Improve testlibpq3.c's example of PQexecParams() usage to include sendingTom Lane2005-10-20
| | | | | | | a parameter in binary format. Also, add a TIP explaining how to use casts in the query text to avoid needing to specify parameter types by OID. Also fix bogus spacing --- apparently somebody expanded the tabs in the example programs to 8 spaces instead of 4 when transposing them into SGML.
* Postpone pg_timezone_initialize() until after creation of postmaster.pid,Tom Lane2005-10-20
| | | | | | | since it can take a fair amount of time and this can confuse boot scripts that expect postmaster.pid to appear quickly. Move initialization of SSL library and preloaded libraries to after that point, too, just for luck. Per reports from Tony Caduto and others.
* Adjust not-too-sane calculation of DDD value for to_char(interval).Tom Lane2005-10-20
| | | | Per gripe from Chris Matheson.
* Clean up md5.c to make it clearer that it is a frontend-and-backendTom Lane2005-10-20
| | | | | | | module. Don't rely on backend palloc semantics; in fact, best to not use palloc at all, rather than #define'ing it to malloc, because that just encourages errors of omission. Bug spotted by Volkan YAZICI, but I went further than he did to fix it.
* Make \d order a table's check constraints by constraint name insteadTom Lane2005-10-20
| | | | | of the text of the constraint condition. Per Chris K-L, though I didn't use his patch exactly.
* Better solution to the problem of labeling whole-row Datums that areTom Lane2005-10-19
| | | | | | generated from subquery outputs: use the type info stored in the Var itself. To avoid making ExecEvalVar and slot_getattr more complex and slower, I split out the whole-row case into a separate ExecEval routine.
* Ensure that the Datum generated from a whole-row Var contains validTom Lane2005-10-19
| | | | | | type ID information even when it's a record type. This is needed to handle whole-row Vars referencing subquery outputs. Per example from Richard Huxton.
* Fix oversight in recent changes to enable the 'physical tlist'Tom Lane2005-10-19
| | | | | | | | | optimization for subquery and function scan nodes: we can't just do it unconditionally, we still have to check whether there is any need for a whole-row Var. I had been thinking that these node types couldn't have any system columns, which is true, but that loop is also checking for attno zero, ie, whole-row Var. Fix comment to not be so misleading. Per test case from Richard Huxton.
* Improve trace_sort code to also show the total memory or disk space used.Tom Lane2005-10-18
| | | | Per request from Marc.
* Code review for regexp_replace patch. Improve documentation and comments,Tom Lane2005-10-18
| | | | | | | fix problems with replacement-string backslashes that aren't followed by one of the expected characters, avoid giving the impression that replace_text_regexp() is meant to be called directly as a SQL function, etc.
* Code review for spi_query/spi_fetchrow patch: handle errors sanely,Tom Lane2005-10-18
| | | | | avoid leaking memory. I would add a regression test for error handling except it seems eval{} can't be used in unprivileged plperl :-(
* A few trivial code cleanups motivated by reading warnings generatedTom Lane2005-10-18
| | | | | by a recent HP C compiler. Mostly, get rid of useless local variables that are assigned to but never used.
* Clean up libpq's pollution of application namespace by renaming theTom Lane2005-10-17
| | | | | | exported routines of ip.c, md5.c, and fe-auth.c to begin with 'pg_'. Also get rid of the vestigial fe_setauthsvc/fe_getauthsvc routines altogether.
* Add space after description.Bruce Momjian2005-10-16
| | | | Euler Taveira de Oliveira
* kerberos error message: localhost -> server hostnameBruce Momjian2005-10-15
|
* Fix thinko in pg_read_file: testing for negative result is not the wayTom Lane2005-10-15
| | | | to determine whether fread() failed.
* Standard pgindent run for 8.1.Bruce Momjian2005-10-15
|
* Update pgindent typedef list.Bruce Momjian2005-10-15
|
* Fix syslog bug: if any messages are emitted to write_syslog beforeTom Lane2005-10-14
| | | | | | | | | the facility has been set, the facility gets set to LOCAL0 and cannot be changed later. This seems reasonably plausible to happen, particularly at higher debug log levels, though I am not certain it explains Han Holl's recent report. Easiest fix is to teach the code how to change the value on-the-fly, which is nicer anyway. I made the settings PGC_SIGHUP to conform with log_destination.
* Pass a strdup'd ident string to openlog(), to ensure that reallocationTom Lane2005-10-14
| | | | | of GUC memory doesn't cause us to start emitting a bogus ident string. Per report from Han Holl. Also some trivial code cleanup in write_syslog.
* Allow times of 24:00:00 to match rounding behavior:Bruce Momjian2005-10-14
| | | | | | | | | | | | | | | regression=# select '23:59:59.9'::time(0); time ---------- 24:00:00 (1 row) This is bad because: regression=# select '24:00:00'::time(0); ERROR: date/time field value out of range: "24:00:00" The last example now works.
* Fix uppercase TRUE/FALSE that are WIN32 stuffl.Bruce Momjian2005-10-13
|
* Update regression output for new prepare transaction error messages.Bruce Momjian2005-10-13
|
* Make stack_base_ptr non-static, for PL/Java.Bruce Momjian2005-10-13
|
* This makes the error messages for PREPARE TRANSACTION, COMMIT PREPAREDBruce Momjian2005-10-13
| | | | | | | etc. match the docs, which talk about "transaction identifier" not "gid" or "global transaction identifier". Steve Woodcock
* Update krb_server_name to document that a missing entry defaults toBruce Momjian2005-10-13
| | | | | | 'localhost'. Improve kerberos error message.
* The patch updates the documentation to reflect the fact that higher valuesBruce Momjian2005-10-13
| | | | | | | | | | | | | | | | | | | | of client_min_messages (fatal + panic) are valid and also fixes a slight issue with how psql tried to display error messages that aren't sent to the client. We often tell people to ignore errors in response to requests for things like "drop if exists", but there's no good way to completely hide this without upping client_min_messages past ERROR. When running a file like SET client_min_messages TO 'FATAL'; DROP TABLE doesntexist; with "psql -f filename" you get an error prefix of "psql:/home/username/filename:3" even though there is no error message to prefix because it isn't sent to the client. Kris Jurka
* Go back to emitting path names with forward slashes on Windows.Tom Lane2005-10-13
| | | | | I'm not clear on what the double-backslash idea was intended to fix, but it breaks at least mingw GNU Make. Per report from Thomas Hallgren.
* Back out this because of fear of changing error strings:Bruce Momjian2005-10-13
| | | | | | | | This makes the error messages for PREPARE TRANSACTION, COMMIT PREPARED etc. match the docs, which talk about "transaction identifier" not "gid" or "global transaction identifier". Steve Woodcock
* This makes the error messages for PREPARE TRANSACTION, COMMIT PREPAREDBruce Momjian2005-10-13
| | | | | | | etc. match the docs, which talk about "transaction identifier" not "gid" or "global transaction identifier". Steve Woodcock
* Use get_progname() in backend main.c, rather than port-specific hackBruce Momjian2005-10-13
| | | | that is too fragile.
* Fix small oversight in recent patch to add more CREATE-FUNCTION-timeTom Lane2005-10-13
| | | | | | syntax checking to plpgsql: check_sql_expr() wasn't being called by make_select_stmt(), so that there was no SQL syntax check for SELECT statements.
* Remove an antiquated comment.Neil Conway2005-10-13
|
* Add a comment describing the requirement that pointers into shared memoryNeil Conway2005-10-13
| | | | that is protected by a spinlock must be volatile, per recent discussion.
* Don't try to remove duplicate OR-subclauses in create_bitmap_subplan andTom Lane2005-10-13
| | | | | | | make_restrictinfo_from_bitmapqual. The likelihood of finding duplicates seems much less than in the AND-subclause case, and the cost much higher, because OR lists with hundreds or even thousands of subclauses are not uncommon. Per discussion with Ilia Kantor and andrew@supernews.
* Fix longstanding bug found by Atsushi Ogawa: _bt_check_unique would markTom Lane2005-10-12
| | | | | | the wrong buffer dirty when trying to kill a dead index entry that's on a page after the one it started on. No risk of data corruption, just inefficiency, but still a bug.
* Fix another recently-changed place that was messing with spinlock-Tom Lane2005-10-12
| | | | protected data structures and not using a volatile pointer for same.
* Do all accesses to shared buffer headers through volatile-qualifiedTom Lane2005-10-12
| | | | | | | pointers, to ensure that compilers won't rearrange accesses to occur while we're not holding the buffer header spinlock. It's probably not necessary to mark volatile in every single place in bufmgr.c, but better safe than sorry. Per trouble report from Kevin Grittner.
* Fix typo in sample pg_hba.conf; per IRC report from Bernhard Neuhauser.Neil Conway2005-10-11
|
* Add infrastructure for making spins_per_delay variable depending onTom Lane2005-10-11
| | | | | | whether we seem to be running in a uniprocessor or multiprocessor. The adjustment rules could probably still use further tweaking, but I'm convinced this should be a win overall.
* Don't use a non-locked pre-test of the spinlock on x86_64 machines.Tom Lane2005-10-11
| | | | | The pre-test has been shown to be a big loss on Opterons and at best a wash on EM64T.
* Document that get_attstatsslot/free_attstatsslot only need to be passedTom Lane2005-10-11
| | | | | | | | valid type information if they are asked to fetch the values part of a pg_statistic slot; these arguments are unneeded if fetching only the numbers part. Use this to save a catcache lookup in btcostestimate, which is looking like a bit of a hotspot in recent profiling. Not a big savings, but since it's essentially free, might as well do it.
* Fix oversight in 8.0 modification of RestrictInfo data structures.Tom Lane2005-10-11
| | | | | | | | A RestrictInfo representing an OR clause now contains two versions of the contained expression, one with sub-RestrictInfos and one without. clause_selectivity() should descend to the version with sub-RestrictInfos so that it has a chance of caching its results for the OR's sub-clauses. Failing to do so resulted in redundant planner effort.
* Remove the DELETEs from pg_shadow and pg_group that pg_dumpall used toTom Lane2005-10-10
| | | | | | | | emit when given the --clean option, in favor of individual DROP ROLE commands. The old technique could not possibly work in 8.1, and was never a very good idea anyway IMHO. The DROP ROLE approach has the defect that the DROPs will fail for roles that own objects or have privileges, but perhaps we can improve that later.
* Use a safer order of operations in dropdb(): rollbackable operations,Tom Lane2005-10-10
| | | | | | ie removing shared-dependency entries, should happen before non-rollbackable ones. That way a failure during the rollbackable part doesn't leave us with inconsistent state.
* Document the process to update translations.Peter Eisentraut2005-10-10
|
* Translation updatePeter Eisentraut2005-10-10
|
* Fix the problem of GRANTs creating "dangling" privileges not directlyTom Lane2005-10-10
| | | | | | traceable to grant options. As per my earlier proposal, a GRANT made by a role member has to be recorded as being granted by the role that actually holds the grant option, and not the member.
* <limits.h> is now needed here, for INT_MAX. Per Michael Fuhr.Tom Lane2005-10-10
|
* Fix (hopefully for the last time) problems with datetime values displayingTom Lane2005-10-09
| | | | | | | like '23:59:60' because of fractional-second roundoff problems. Trying to control this upstream of the actual display code was hopeless; the right way is to explicitly round fractional seconds in the display code and then refigure the results if the fraction rounds up to 1. Per bug #1927.