From c8b2ef05f481ef06326d7b9f3eb14b303f215c7e Mon Sep 17 00:00:00 2001 From: Peter Eisentraut Date: Tue, 27 Sep 2022 20:47:07 +0200 Subject: Convert *GetDatum() and DatumGet*() macros to inline functions The previous macro implementations just cast the argument to a target type but did not check whether the input type was appropriate. The function implementation can do better type checking of the input type. For the *GetDatumFast() macros, converting to an inline function doesn't work in the !USE_FLOAT8_BYVAL case, but we can use AssertVariableIsOfTypeMacro() to get a similar level of type checking. Reviewed-by: Aleksander Alekseev Reviewed-by: Tom Lane Discussion: https://www.postgresql.org/message-id/flat/8528fb7e-0aa2-6b54-85fb-0c0886dbd6ed%40enterprisedb.com --- contrib/intarray/_int_gist.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'contrib/intarray/_int_gist.c') diff --git a/contrib/intarray/_int_gist.c b/contrib/intarray/_int_gist.c index f1817a6cce3..6378aa74b07 100644 --- a/contrib/intarray/_int_gist.c +++ b/contrib/intarray/_int_gist.c @@ -51,7 +51,7 @@ g_int_consistent(PG_FUNCTION_ARGS) /* Oid subtype = PG_GETARG_OID(3); */ bool *recheck = (bool *) PG_GETARG_POINTER(4); - bool retval; + bool retval = false; /* silence compiler warning */ /* this is exact except for RTSameStrategyNumber */ *recheck = (strategy == RTSameStrategyNumber); -- cgit v1.2.3