From fc02b87e2876b2492a3d5eebd3b70be383b08f40 Mon Sep 17 00:00:00 2001 From: Bruce Momjian Date: Thu, 17 Apr 2014 12:37:53 -0400 Subject: pgcrypto: fix memset() calls that might be optimized away Specifically, on-stack memset() might be removed, so: * Replace memset() with px_memset() * Add px_memset to copy_crlf() * Add px_memset to pgp-s2k.c Patch by Marko Kreen Report by PVS-Studio Backpatch through 8.4. --- contrib/pgcrypto/pgp-mpi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'contrib/pgcrypto/pgp-mpi.c') diff --git a/contrib/pgcrypto/pgp-mpi.c b/contrib/pgcrypto/pgp-mpi.c index c8765b6d141..0daca3cda48 100644 --- a/contrib/pgcrypto/pgp-mpi.c +++ b/contrib/pgcrypto/pgp-mpi.c @@ -72,7 +72,7 @@ pgp_mpi_free(PGP_MPI *mpi) { if (mpi == NULL) return 0; - memset(mpi, 0, sizeof(*mpi) + mpi->bytes); + px_memset(mpi, 0, sizeof(*mpi) + mpi->bytes); px_free(mpi); return 0; } -- cgit v1.2.3