From 04c8634c0c4d636540c9283efdd695558403dc4e Mon Sep 17 00:00:00 2001 From: Peter Eisentraut Date: Mon, 17 Jun 2024 09:42:51 +0200 Subject: pg_createsubscriber: Only --recovery-timeout controls the end of recovery process It used to check if the target server is connected to the primary server (send required WAL) to rapidly react when the process won't succeed. This code is not enough to guarantee that the recovery process will complete. There is a window between the walreceiver shutdown and the pg_is_in_recovery() returns false that can reach NUM_CONN_ATTEMPTS attempts and fails. Instead, rely only on the --recovery-timeout option to give up the process after the specified number of seconds. This should help with buildfarm failures on slow machines. Author: Euler Taveira Reviewed-by: Hayato Kuroda Discussion: https://www.postgresql.org/message-id/776c5cac-5ef5-4001-b1bc-5b698bc0c62a%40app.fastmail.com --- doc/src/sgml/ref/pg_createsubscriber.sgml | 7 ------- 1 file changed, 7 deletions(-) (limited to 'doc/src') diff --git a/doc/src/sgml/ref/pg_createsubscriber.sgml b/doc/src/sgml/ref/pg_createsubscriber.sgml index 142bffff023..a700697f887 100644 --- a/doc/src/sgml/ref/pg_createsubscriber.sgml +++ b/doc/src/sgml/ref/pg_createsubscriber.sgml @@ -325,13 +325,6 @@ PostgreSQL documentation connections to the target server should fail. - - During the recovery process, if the target server disconnects from the - source server, pg_createsubscriber will check a - few times if the connection has been reestablished to stream the required - WAL. After a few attempts, it terminates with an error. - - Since DDL commands are not replicated by logical replication, avoid executing DDL commands that change the database schema while running -- cgit v1.2.3