From 154146d208de7518bb6c8131dc8d2361f7f36f56 Mon Sep 17 00:00:00 2001
From: Tom Lane <tgl@sss.pgh.pa.us>
Date: Thu, 12 Jun 2014 15:39:09 -0400
Subject: Rename lo_create(oid, bytea) to lo_from_bytea().

The previous naming broke the query that libpq's lo_initialize() uses
to collect the OIDs of the server-side functions it requires, because
that query effectively assumes that there is only one function named
lo_create in the pg_catalog schema (and likewise only one lo_open, etc).

While we should certainly make libpq more robust about this, the naive
query will remain in use in the field for the foreseeable future, so it
seems the only workable choice is to use a different name for the new
function.  lo_from_bytea() won a small straw poll.

Back-patch into 9.4 where the new function was introduced.
---
 doc/src/sgml/lobj.sgml | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

(limited to 'doc/src')

diff --git a/doc/src/sgml/lobj.sgml b/doc/src/sgml/lobj.sgml
index d403586a054..c0174b71bee 100644
--- a/doc/src/sgml/lobj.sgml
+++ b/doc/src/sgml/lobj.sgml
@@ -547,16 +547,16 @@ int lo_unlink(PGconn *conn, Oid lobjId);
      <row>
       <entry>
        <indexterm>
-        <primary>lo_create</primary>
+        <primary>lo_from_bytea</primary>
        </indexterm>
-       <literal><function>lo_create(<parameter>loid</parameter> <type>oid</type>, <parameter>string</parameter> <type>bytea</type>)</function></literal>
+       <literal><function>lo_from_bytea(<parameter>loid</parameter> <type>oid</type>, <parameter>string</parameter> <type>bytea</type>)</function></literal>
       </entry>
       <entry><type>oid</type></entry>
       <entry>
        Create a large object and store data there, returning its OID.
        Pass <literal>0</> to have the system choose an OID.
       </entry>
-      <entry><literal>lo_create(0, E'\\xffffff00')</literal></entry>
+      <entry><literal>lo_from_bytea(0, E'\\xffffff00')</literal></entry>
       <entry><literal>24528</literal></entry>
      </row>
 
-- 
cgit v1.2.3