From e2bab2d792044b55dd092bf1c2be0d570ccb9401 Mon Sep 17 00:00:00 2001 From: Michael Paquier Date: Thu, 3 Oct 2024 10:55:02 +0900 Subject: Remove support for unlogged on partitioned tables The following commands were allowed on partitioned tables, with different effects: 1) ALTER TABLE SET [UN]LOGGED did not issue an error, and did not update pg_class.relpersistence. 2) CREATE UNLOGGED TABLE was working with pg_class.relpersistence marked as initially defined, but partitions did not inherit the UNLOGGED property, which was confusing. This commit causes the commands mentioned above to fail for partitioned tables, instead. pg_dump is tweaked so as partitioned tables marked as UNLOGGED ignore the option when dumped from older server versions. pgbench needs a tweak for --unlogged and --partitions=N to ignore the UNLOGGED option on the partitioned tables created, its partitions still being unlogged. Author: Michael Paquier Reviewed-by: Nathan Bossart Discussion: https://postgr.es/m/ZiiyGFTBNkqcMQi_@paquier.xyz --- doc/src/sgml/ref/alter_table.sgml | 4 ++++ doc/src/sgml/ref/create_table.sgml | 4 ++++ 2 files changed, 8 insertions(+) (limited to 'doc/src') diff --git a/doc/src/sgml/ref/alter_table.sgml b/doc/src/sgml/ref/alter_table.sgml index c5a14674804..36770c012a6 100644 --- a/doc/src/sgml/ref/alter_table.sgml +++ b/doc/src/sgml/ref/alter_table.sgml @@ -797,6 +797,10 @@ WITH ( MODULUS numeric_literal, REM (for identity or serial columns). However, it is also possible to change the persistence of such sequences separately. + + + This form is not supported for partitioned tables. + diff --git a/doc/src/sgml/ref/create_table.sgml b/doc/src/sgml/ref/create_table.sgml index c1855b8d827..83859bac76f 100644 --- a/doc/src/sgml/ref/create_table.sgml +++ b/doc/src/sgml/ref/create_table.sgml @@ -220,6 +220,10 @@ WITH ( MODULUS numeric_literal, REM If this is specified, any sequences created together with the unlogged table (for identity or serial columns) are also created as unlogged. + + + This form is not supported for partitioned tables. + -- cgit v1.2.3