From 6cd015bea38b8a59feb84bf238a880a3b503cf5f Mon Sep 17 00:00:00 2001 From: Robert Haas Date: Thu, 14 Jun 2012 10:11:16 -0400 Subject: Add new function log_newpage_buffer. When I implemented the ginbuildempty() function as part of implementing unlogged tables, I falsified the note in the header comment for log_newpage. Although we could fix that up by changing the comment, it seems cleaner to add a new function which is specifically intended to handle this case. So do that. --- src/backend/access/gin/gininsert.c | 12 +++--------- 1 file changed, 3 insertions(+), 9 deletions(-) (limited to 'src/backend/access/gin/gininsert.c') diff --git a/src/backend/access/gin/gininsert.c b/src/backend/access/gin/gininsert.c index fe06bdcbfab..2f95f718e0b 100644 --- a/src/backend/access/gin/gininsert.c +++ b/src/backend/access/gin/gininsert.c @@ -520,20 +520,14 @@ ginbuildempty(PG_FUNCTION_ARGS) ReadBufferExtended(index, INIT_FORKNUM, P_NEW, RBM_NORMAL, NULL); LockBuffer(RootBuffer, BUFFER_LOCK_EXCLUSIVE); - /* Initialize both pages, mark them dirty, unlock and release buffer. */ + /* Initialize and xlog metabuffer and root buffer. */ START_CRIT_SECTION(); GinInitMetabuffer(MetaBuffer); MarkBufferDirty(MetaBuffer); + log_newpage_buffer(MetaBuffer); GinInitBuffer(RootBuffer, GIN_LEAF); MarkBufferDirty(RootBuffer); - - /* XLOG the new pages */ - log_newpage(&index->rd_smgr->smgr_rnode.node, INIT_FORKNUM, - BufferGetBlockNumber(MetaBuffer), - BufferGetPage(MetaBuffer)); - log_newpage(&index->rd_smgr->smgr_rnode.node, INIT_FORKNUM, - BufferGetBlockNumber(RootBuffer), - BufferGetPage(RootBuffer)); + log_newpage_buffer(RootBuffer); END_CRIT_SECTION(); /* Unlock and release the buffers. */ -- cgit v1.2.3