From 5f7b58fad8f45c69bb67944779dce67e2f481995 Mon Sep 17 00:00:00 2001 From: Robert Haas Date: Mon, 13 Dec 2010 12:34:26 -0500 Subject: Generalize concept of temporary relations to "relation persistence". This commit replaces pg_class.relistemp with pg_class.relpersistence; and also modifies the RangeVar node type to carry relpersistence rather than istemp. It also removes removes rd_istemp from RelationData and instead performs the correct computation based on relpersistence. For clarity, we add three new macros: RelationNeedsWAL(), RelationUsesLocalBuffers(), and RelationUsesTempNamespace(), so that we can clarify the purpose of each check that previous depended on rd_istemp. This is intended as infrastructure for the upcoming unlogged tables patch, as well as for future possible work on global temporary tables. --- src/backend/access/gist/gist.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) (limited to 'src/backend/access/gist/gist.c') diff --git a/src/backend/access/gist/gist.c b/src/backend/access/gist/gist.c index d6aaea2162d..b34830bb424 100644 --- a/src/backend/access/gist/gist.c +++ b/src/backend/access/gist/gist.c @@ -115,7 +115,7 @@ gistbuild(PG_FUNCTION_ARGS) MarkBufferDirty(buffer); - if (!index->rd_istemp) + if (RelationNeedsWAL(index)) { XLogRecPtr recptr; XLogRecData rdata; @@ -401,7 +401,7 @@ gistplacetopage(GISTInsertState *state, GISTSTATE *giststate) dist->page = BufferGetPage(dist->buffer); } - if (!state->r->rd_istemp) + if (RelationNeedsWAL(state->r)) { XLogRecPtr recptr; XLogRecData *rdata; @@ -465,7 +465,7 @@ gistplacetopage(GISTInsertState *state, GISTSTATE *giststate) MarkBufferDirty(state->stack->buffer); - if (!state->r->rd_istemp) + if (RelationNeedsWAL(state->r)) { OffsetNumber noffs = 0, offs[1]; @@ -550,7 +550,7 @@ gistfindleaf(GISTInsertState *state, GISTSTATE *giststate) opaque = GistPageGetOpaque(state->stack->page); state->stack->lsn = PageGetLSN(state->stack->page); - Assert(state->r->rd_istemp || !XLogRecPtrIsInvalid(state->stack->lsn)); + Assert(!RelationNeedsWAL(state->r) || !XLogRecPtrIsInvalid(state->stack->lsn)); if (state->stack->blkno != GIST_ROOT_BLKNO && XLByteLT(state->stack->parent->lsn, opaque->nsn)) @@ -911,7 +911,7 @@ gistmakedeal(GISTInsertState *state, GISTSTATE *giststate) } /* say to xlog that insert is completed */ - if (state->needInsertComplete && !state->r->rd_istemp) + if (state->needInsertComplete && RelationNeedsWAL(state->r)) gistxlogInsertCompletion(state->r->rd_node, &(state->key), 1); } @@ -1011,7 +1011,7 @@ gistnewroot(Relation r, Buffer buffer, IndexTuple *itup, int len, ItemPointer ke MarkBufferDirty(buffer); - if (!r->rd_istemp) + if (RelationNeedsWAL(r)) { XLogRecPtr recptr; XLogRecData *rdata; -- cgit v1.2.3