From ff7b9f55410bbfbd017af331d23371ab61b63d5e Mon Sep 17 00:00:00 2001 From: Tom Lane Date: Wed, 14 Jun 2000 05:24:50 +0000 Subject: I had overlooked the fact that some fmgr-callable functions return void --- ie, they're only called for side-effects. Add a PG_RETURN_VOID() macro and use it where appropriate. This probably doesn't change the machine code by a single bit ... it's just for documentation. --- src/backend/access/gist/gistscan.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) (limited to 'src/backend/access/gist/gistscan.c') diff --git a/src/backend/access/gist/gistscan.c b/src/backend/access/gist/gistscan.c index 729837e8008..d37a8c07763 100644 --- a/src/backend/access/gist/gistscan.c +++ b/src/backend/access/gist/gistscan.c @@ -154,7 +154,7 @@ gistrescan(PG_FUNCTION_ARGS) } } - PG_RETURN_POINTER(NULL); /* no real return value */ + PG_RETURN_VOID(); } Datum @@ -190,7 +190,7 @@ gistmarkpos(PG_FUNCTION_ARGS) gistfreestack(p->s_markstk); p->s_markstk = o; - PG_RETURN_POINTER(NULL); /* no real return value */ + PG_RETURN_VOID(); } Datum @@ -226,7 +226,7 @@ gistrestrpos(PG_FUNCTION_ARGS) gistfreestack(p->s_stack); p->s_stack = o; - PG_RETURN_POINTER(NULL); /* no real return value */ + PG_RETURN_VOID(); } Datum @@ -247,7 +247,7 @@ gistendscan(PG_FUNCTION_ARGS) gistdropscan(s); /* XXX don't unset read lock -- two-phase locking */ - PG_RETURN_POINTER(NULL); /* no real return value */ + PG_RETURN_VOID(); } static void -- cgit v1.2.3