From e6af7b367cf46fc385307efcef5a1fece0e5fef3 Mon Sep 17 00:00:00 2001 From: Alexander Korotkov Date: Sun, 8 Sep 2019 21:13:40 +0300 Subject: Fix handling of NULL distances in KNN-GiST In order to implement NULL LAST semantic GiST previously assumed distance to the NULL value to be Inf. However, our distance functions can return Inf and NaN for non-null values. In such cases, NULL LAST semantic appears to be broken. This commit fixes that by introducing separate array of null flags for distances. Backpatch to all supported versions. Discussion: https://postgr.es/m/CAPpHfdsNvNdA0DBS%2BwMpFrgwT6C3-q50sFVGLSiuWnV3FqOJuQ%40mail.gmail.com Author: Alexander Korotkov Backpatch-through: 9.4 --- src/backend/access/spgist/spgscan.c | 1 + 1 file changed, 1 insertion(+) (limited to 'src/backend/access/spgist/spgscan.c') diff --git a/src/backend/access/spgist/spgscan.c b/src/backend/access/spgist/spgscan.c index 7bc5ec09bf9..bf83cc8016c 100644 --- a/src/backend/access/spgist/spgscan.c +++ b/src/backend/access/spgist/spgscan.c @@ -934,6 +934,7 @@ spggettuple(IndexScanDesc scan, ScanDirection dir) if (so->numberOfOrderBys > 0) index_store_float8_orderby_distances(scan, so->orderByTypes, so->distances[so->iPtr], + NULL, so->recheckDistances[so->iPtr]); so->iPtr++; return true; -- cgit v1.2.3