From 001a573a2011d605f2a6e10aee9996de8581d099 Mon Sep 17 00:00:00 2001 From: Robert Haas Date: Wed, 18 Dec 2013 12:57:20 -0500 Subject: Allow on-detach callbacks for dynamic shared memory segments. Just as backends must clean up their shared memory state (releasing lwlocks, buffer pins, etc.) before exiting, they must also perform any similar cleanups related to dynamic shared memory segments they have mapped before unmapping those segments. So add a mechanism to ensure that. Existing on_shmem_exit hooks include both "user level" cleanup such as transaction abort and removal of leftover temporary relations and also "low level" cleanup that forcibly released leftover shared memory resources. On-detach callbacks should run after the first group but before the second group, so create a new before_shmem_exit function for registering the early callbacks and keep on_shmem_exit for the regular callbacks. (An earlier draft of this patch added an additional argument to on_shmem_exit, but that had a much larger footprint and probably a substantially higher risk of breaking third party code for no real gain.) Patch by me, reviewed by KaiGai Kohei and Andres Freund. --- src/backend/commands/async.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'src/backend/commands/async.c') diff --git a/src/backend/commands/async.c b/src/backend/commands/async.c index f4526a6c4d9..5311e1fe9a8 100644 --- a/src/backend/commands/async.c +++ b/src/backend/commands/async.c @@ -921,7 +921,7 @@ Exec_ListenPreCommit(void) */ if (!unlistenExitRegistered) { - on_shmem_exit(Async_UnlistenOnExit, 0); + before_shmem_exit(Async_UnlistenOnExit, 0); unlistenExitRegistered = true; } -- cgit v1.2.3