From 53e95eee84e0f8c680ad813091e7226abb24214e Mon Sep 17 00:00:00 2001 From: Tom Lane Date: Mon, 16 Sep 2002 01:24:41 +0000 Subject: Fix for rare race-condition-like failure: if a backend receives SIGUSR2 (notify/SI-overrun interrupt) while it is in process of doing proc_exit, it is possible for Async_NotifyHandler() to try to start a transaction when one is already running. This leads to Asserts() or worse. I think it may only be possible to occur when frontend synchronization is lost (ie, the elog(FATAL) in SocketBackend() fires), but that is a standard occurrence after error during COPY. In any case, I have seen this failure occur during regression tests, so it is definitely possible. --- src/backend/commands/async.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) (limited to 'src/backend/commands/async.c') diff --git a/src/backend/commands/async.c b/src/backend/commands/async.c index 1945c751e18..a3c27b8f810 100644 --- a/src/backend/commands/async.c +++ b/src/backend/commands/async.c @@ -7,7 +7,7 @@ * Portions Copyright (c) 1994, Regents of the University of California * * IDENTIFICATION - * $Header: /cvsroot/pgsql/src/backend/commands/async.c,v 1.90 2002/09/02 02:47:01 momjian Exp $ + * $Header: /cvsroot/pgsql/src/backend/commands/async.c,v 1.91 2002/09/16 01:24:41 tgl Exp $ * *------------------------------------------------------------------------- */ @@ -593,6 +593,10 @@ Async_NotifyHandler(SIGNAL_ARGS) * ever turned on. */ + /* Don't joggle the elbow of proc_exit */ + if (proc_exit_inprogress) + return; + if (notifyInterruptEnabled) { /* -- cgit v1.2.3