From 604bd3671121b51f977de146ed95484c2297fb3e Mon Sep 17 00:00:00 2001 From: Peter Eisentraut Date: Fri, 1 Nov 2019 11:09:52 +0100 Subject: PG_FINALLY This gives an alternative way of catching exceptions, for the common case where the cleanup code is the same in the error and non-error cases. So instead of PG_TRY(); { ... code that might throw ereport(ERROR) ... } PG_CATCH(); { cleanup(); PG_RE_THROW(); } PG_END_TRY(); cleanup(); one can write PG_TRY(); { ... code that might throw ereport(ERROR) ... } PG_FINALLY(); { cleanup(); } PG_END_TRY(); Discussion: https://www.postgresql.org/message-id/flat/95a822c3-728b-af0e-d7e5-71890507ae0c%402ndquadrant.com --- src/backend/commands/copy.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) (limited to 'src/backend/commands/copy.c') diff --git a/src/backend/commands/copy.c b/src/backend/commands/copy.c index 3aeef30b281..e17d8c760f7 100644 --- a/src/backend/commands/copy.c +++ b/src/backend/commands/copy.c @@ -1916,13 +1916,11 @@ BeginCopyTo(ParseState *pstate, { cstate->copy_file = AllocateFile(cstate->filename, PG_BINARY_W); } - PG_CATCH(); + PG_FINALLY(); { umask(oumask); - PG_RE_THROW(); } PG_END_TRY(); - umask(oumask); if (cstate->copy_file == NULL) { /* copy errno because ereport subfunctions might change it */ -- cgit v1.2.3