From 7c5c4e1c0396b0617a6f9b659dd7375fb0bfb9dc Mon Sep 17 00:00:00 2001 From: Noah Misch Date: Mon, 31 Jul 2023 17:04:47 -0700 Subject: Remove PushOverrideSearchPath() and PopOverrideSearchPath(). Since commit 681d9e4621aac0a9c71364b6f54f00f6d8c4337f, they have no in-tree calls. Any new calls would introduce security vulnerabilities like the one fixed in that commit. Alexander Lakhin, reviewed by Aleksander Alekseev. Discussion: https://postgr.es/m/8ffb4650-52c4-6a81-38fc-8f99be981130@gmail.com --- src/backend/commands/extension.c | 5 ----- 1 file changed, 5 deletions(-) (limited to 'src/backend/commands/extension.c') diff --git a/src/backend/commands/extension.c b/src/backend/commands/extension.c index 9a2ee1c6008..4cc994ca31e 100644 --- a/src/backend/commands/extension.c +++ b/src/backend/commands/extension.c @@ -967,11 +967,6 @@ execute_extension_script(Oid extensionOid, ExtensionControlFile *control, * searched anyway. (Listing pg_catalog explicitly in a non-first * position would be bad for security.) Finally add pg_temp to ensure * that temp objects can't take precedence over others. - * - * Note: it might look tempting to use PushOverrideSearchPath for this, - * but we cannot do that. We have to actually set the search_path GUC in - * case the extension script examines or changes it. In any case, the - * GUC_ACTION_SAVE method is just as convenient. */ initStringInfo(&pathbuf); appendStringInfoString(&pathbuf, quote_identifier(schemaName)); -- cgit v1.2.3