From 52eec1c53aa6a7df1683fba79078793f1d0eba42 Mon Sep 17 00:00:00 2001 From: Alvaro Herrera Date: Sat, 7 Nov 2020 19:33:43 -0300 Subject: Message style improvements * Avoid pointlessly highlighting that an index vacuum was executed by a parallel worker; user doesn't care. * Don't give the impression that a non-concurrent reindex of an invalid index on a TOAST table would work, because it wouldn't. * Add a "translator:" comment for a mysterious message. Discussion: https://postgr.es/m/20201107034943.GA16596@alvherre.pgsql Reviewed-by: Michael Paquier --- src/backend/commands/indexcmds.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) (limited to 'src/backend/commands/indexcmds.c') diff --git a/src/backend/commands/indexcmds.c b/src/backend/commands/indexcmds.c index 75552c64ed2..3522f4b6a69 100644 --- a/src/backend/commands/indexcmds.c +++ b/src/backend/commands/indexcmds.c @@ -3187,13 +3187,14 @@ ReindexRelationConcurrently(Oid relationOid, int options) /* * Don't allow reindex for an invalid index on TOAST table, as - * if rebuilt it would not be possible to drop it. + * if rebuilt it would not be possible to drop it. Match + * error message in reindex_index(). */ if (IsToastNamespace(get_rel_namespace(relationOid)) && !get_index_isvalid(relationOid)) ereport(ERROR, (errcode(ERRCODE_FEATURE_NOT_SUPPORTED), - errmsg("cannot reindex invalid index on TOAST table concurrently"))); + errmsg("cannot reindex invalid index on TOAST table"))); /* * Check if parent relation can be locked and if it exists, -- cgit v1.2.3