From bbbe825f5f46d7ead60502f43d3b414719a41aa5 Mon Sep 17 00:00:00 2001 From: Tom Lane Date: Fri, 27 Apr 2007 22:05:49 +0000 Subject: Modify processing of DECLARE CURSOR and EXPLAIN so that they can resolve the types of unspecified parameters when submitted via extended query protocol. This worked in 8.2 but I had broken it during plancache changes. DECLARE CURSOR is now treated almost exactly like a plain SELECT through parse analysis, rewrite, and planning; only just before sending to the executor do we divert it away to ProcessUtility. This requires a special-case check in a number of places, but practically all of them were already special-casing SELECT INTO, so it's not too ugly. (Maybe it would be a good idea to merge the two by treating IntoClause as a form of utility statement? Not going to worry about that now, though.) That approach doesn't work for EXPLAIN, however, so for that I punted and used a klugy solution of running parse analysis an extra time if under extended query protocol. --- src/backend/commands/prepare.c | 24 +++++++++--------------- 1 file changed, 9 insertions(+), 15 deletions(-) (limited to 'src/backend/commands/prepare.c') diff --git a/src/backend/commands/prepare.c b/src/backend/commands/prepare.c index e9b953f709a..997f66c8188 100644 --- a/src/backend/commands/prepare.c +++ b/src/backend/commands/prepare.c @@ -10,7 +10,7 @@ * Copyright (c) 2002-2007, PostgreSQL Global Development Group * * IDENTIFICATION - * $PostgreSQL: pgsql/src/backend/commands/prepare.c,v 1.74 2007/04/26 23:24:44 tgl Exp $ + * $PostgreSQL: pgsql/src/backend/commands/prepare.c,v 1.75 2007/04/27 22:05:47 tgl Exp $ * *------------------------------------------------------------------------- */ @@ -57,7 +57,6 @@ PrepareQuery(PrepareStmt *stmt, const char *queryString) int nargs; List *queries; Query *query; - const char *commandTag; List *query_list, *plan_list; int i; @@ -137,22 +136,15 @@ PrepareQuery(PrepareStmt *stmt, const char *queryString) switch (query->commandType) { case CMD_SELECT: - commandTag = "SELECT"; - break; case CMD_INSERT: - commandTag = "INSERT"; - break; case CMD_UPDATE: - commandTag = "UPDATE"; - break; case CMD_DELETE: - commandTag = "DELETE"; + /* OK */ break; default: ereport(ERROR, (errcode(ERRCODE_INVALID_PSTATEMENT_DEFINITION), errmsg("utility statements cannot be prepared"))); - commandTag = NULL; /* keep compiler quiet */ break; } @@ -168,7 +160,7 @@ PrepareQuery(PrepareStmt *stmt, const char *queryString) StorePreparedStatement(stmt->name, stmt->query, queryString, - commandTag, + CreateCommandTag((Node *) query), argtypes, nargs, 0, /* default cursor options */ @@ -244,11 +236,12 @@ ExecuteQuery(ExecuteStmt *stmt, const char *queryString, errmsg("prepared statement is not a SELECT"))); pstmt = (PlannedStmt *) linitial(plan_list); if (!IsA(pstmt, PlannedStmt) || - pstmt->commandType != CMD_SELECT) + pstmt->commandType != CMD_SELECT || + pstmt->utilityStmt != NULL) ereport(ERROR, (errcode(ERRCODE_WRONG_OBJECT_TYPE), errmsg("prepared statement is not a SELECT"))); - pstmt->into = copyObject(stmt->into); + pstmt->intoClause = copyObject(stmt->into); MemoryContextSwitchTo(oldContext); @@ -689,7 +682,8 @@ ExplainExecuteQuery(ExecuteStmt *execstmt, ExplainStmt *stmt, if (execstmt->into) { - if (pstmt->commandType != CMD_SELECT) + if (pstmt->commandType != CMD_SELECT || + pstmt->utilityStmt != NULL) ereport(ERROR, (errcode(ERRCODE_WRONG_OBJECT_TYPE), errmsg("prepared statement is not a SELECT"))); @@ -697,7 +691,7 @@ ExplainExecuteQuery(ExecuteStmt *execstmt, ExplainStmt *stmt, /* Copy the stmt so we can modify it */ pstmt = copyObject(pstmt); - pstmt->into = execstmt->into; + pstmt->intoClause = execstmt->into; } /* -- cgit v1.2.3