From b75ccddcd6f747dc386411eeac6bbfdface14a2c Mon Sep 17 00:00:00 2001 From: Alvaro Herrera Date: Thu, 7 Nov 2019 13:59:24 -0300 Subject: Fix SET CONSTRAINTS .. DEFERRED on partitioned tables SET CONSTRAINTS ... DEFERRED failed on partitioned tables, because of a sanity check that ensures that the affected constraints have triggers. On partitioned tables, the triggers are in the leaf partitions, not in the partitioned relations themselves, so the sanity check fails. Removing the sanity check solves the problem, because the code needed to support the case is already there. Backpatch to 11. Note: deferred unique constraints are not affected by this bug, because they do have triggers in the parent partitioned table. I did not add a test for this scenario. Discussion: https://postgr.es/m/20191105212915.GA11324@alvherre.pgsql --- src/backend/commands/trigger.c | 10 ---------- 1 file changed, 10 deletions(-) (limited to 'src/backend/commands/trigger.c') diff --git a/src/backend/commands/trigger.c b/src/backend/commands/trigger.c index 57c98912d58..e2048c19f79 100644 --- a/src/backend/commands/trigger.c +++ b/src/backend/commands/trigger.c @@ -5512,13 +5512,10 @@ AfterTriggerSetState(ConstraintsSetStmt *stmt) foreach(lc, conoidlist) { Oid conoid = lfirst_oid(lc); - bool found; ScanKeyData skey; SysScanDesc tgscan; HeapTuple htup; - found = false; - ScanKeyInit(&skey, Anum_pg_trigger_tgconstraint, BTEqualStrategyNumber, F_OIDEQ, @@ -5539,16 +5536,9 @@ AfterTriggerSetState(ConstraintsSetStmt *stmt) */ if (pg_trigger->tgdeferrable) tgoidlist = lappend_oid(tgoidlist, pg_trigger->oid); - - found = true; } systable_endscan(tgscan); - - /* Safety check: a deferrable constraint should have triggers */ - if (!found) - elog(ERROR, "no triggers found for constraint with OID %u", - conoid); } table_close(tgrel, AccessShareLock); -- cgit v1.2.3