From f54d97c5ef58b436a21373537f85bf5ac8159d8c Mon Sep 17 00:00:00 2001 From: Tom Lane Date: Mon, 21 Jul 2014 22:41:30 -0400 Subject: Reject out-of-range numeric timezone specifications. In commit 631dc390f49909a5c8ebd6002cfb2bcee5415a9d, we started to handle simple numeric timezone offsets via the zic library instead of the old CTimeZone/HasCTZSet kluge. However, we overlooked the fact that the zic code will reject UTC offsets exceeding a week (which seems a bit arbitrary, but not because it's too tight ...). This led to possibly setting session_timezone to NULL, which results in crashes in most timezone-related operations as of 9.4, and crashes in a small number of places even before that. So check for NULL return from pg_tzset_offset() and report an appropriate error message. Per bug #11014 from Duncan Gillis. Back-patch to all supported branches, like the previous patch. (Unfortunately, as of today that no longer includes 8.4.) --- src/backend/commands/variable.c | 7 +++++++ 1 file changed, 7 insertions(+) (limited to 'src/backend/commands/variable.c') diff --git a/src/backend/commands/variable.c b/src/backend/commands/variable.c index e6d65c175d6..64fbf28a1e1 100644 --- a/src/backend/commands/variable.c +++ b/src/backend/commands/variable.c @@ -372,6 +372,13 @@ check_timezone(char **newval, void **extra, GucSource source) } } + /* Test for failure in pg_tzset_offset, which we assume is out-of-range */ + if (!myextra.session_timezone) + { + GUC_check_errdetail("UTC timezone offset is out of range."); + return false; + } + /* * Prepare the canonical string to return. GUC wants it malloc'd. * -- cgit v1.2.3