From fe66125974c58cc749ba441ff53e72216c819da0 Mon Sep 17 00:00:00 2001 From: Alvaro Herrera Date: Tue, 3 Sep 2019 14:47:29 -0400 Subject: Remove 'msg' parameter from convert_tuples_by_name The message was included as a parameter when this function was added in dcb2bda9b704, but I don't think it has ever served any useful purpose. Let's stop spreading it pointlessly. Reviewed by Amit Langote and Peter Eisentraut. Discussion: https://postgr.es/m/20190806224728.GA17233@alvherre.pgsql --- src/backend/executor/execMain.c | 12 ++++-------- 1 file changed, 4 insertions(+), 8 deletions(-) (limited to 'src/backend/executor/execMain.c') diff --git a/src/backend/executor/execMain.c b/src/backend/executor/execMain.c index 7f494abf14a..f05fc37f378 100644 --- a/src/backend/executor/execMain.c +++ b/src/backend/executor/execMain.c @@ -1861,8 +1861,7 @@ ExecPartitionCheckEmitError(ResultRelInfo *resultRelInfo, old_tupdesc = RelationGetDescr(resultRelInfo->ri_RelationDesc); /* a reverse map */ - map = convert_tuples_by_name_map_if_req(old_tupdesc, tupdesc, - gettext_noop("could not convert row type")); + map = convert_tuples_by_name_map_if_req(old_tupdesc, tupdesc); /* * Partition-specific slot's tupdesc can't be changed, so allocate a @@ -1947,8 +1946,7 @@ ExecConstraints(ResultRelInfo *resultRelInfo, tupdesc = RelationGetDescr(rel); /* a reverse map */ map = convert_tuples_by_name_map_if_req(orig_tupdesc, - tupdesc, - gettext_noop("could not convert row type")); + tupdesc); /* * Partition-specific slot's tupdesc can't be changed, so @@ -1997,8 +1995,7 @@ ExecConstraints(ResultRelInfo *resultRelInfo, tupdesc = RelationGetDescr(rel); /* a reverse map */ map = convert_tuples_by_name_map_if_req(old_tupdesc, - tupdesc, - gettext_noop("could not convert row type")); + tupdesc); /* * Partition-specific slot's tupdesc can't be changed, so @@ -2105,8 +2102,7 @@ ExecWithCheckOptions(WCOKind kind, ResultRelInfo *resultRelInfo, tupdesc = RelationGetDescr(rel); /* a reverse map */ map = convert_tuples_by_name_map_if_req(old_tupdesc, - tupdesc, - gettext_noop("could not convert row type")); + tupdesc); /* * Partition-specific slot's tupdesc can't be changed, -- cgit v1.2.3