From c759395617765c5bc21db149cf8c3df52f41ccff Mon Sep 17 00:00:00 2001 From: Robert Haas Date: Thu, 4 Jan 2018 07:56:09 -0500 Subject: Code review for Parallel Append. - Remove unnecessary #include mistakenly added in execnodes.h. - Fix mistake in comment in choose_next_subplan_for_leader. - Adjust row estimates in cost_append for a possibly-different parallel divisor. - Clamp row estimates in cost_append after operations that may not produce integers. Amit Kapila, with cosmetic adjustments by me. Discussion: http://postgr.es/m/CAA4eK1+qcbeai3coPpRW=GFCzFeLUsuY4T-AKHqMjxpEGZBPQg@mail.gmail.com --- src/backend/executor/nodeAppend.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) (limited to 'src/backend/executor/nodeAppend.c') diff --git a/src/backend/executor/nodeAppend.c b/src/backend/executor/nodeAppend.c index 4245d8afafe..64a17fb0327 100644 --- a/src/backend/executor/nodeAppend.c +++ b/src/backend/executor/nodeAppend.c @@ -446,10 +446,9 @@ choose_next_subplan_for_leader(AppendState *node) * * We start from the first plan and advance through the list; * when we get back to the end, we loop back to the first - * nonpartial plan. This assigns the non-partial plans first - * in order of descending cost and then spreads out the - * workers as evenly as possible across the remaining partial - * plans. + * partial plan. This assigns the non-partial plans first in + * order of descending cost and then spreads out the workers + * as evenly as possible across the remaining partial plans. * ---------------------------------------------------------------- */ static bool -- cgit v1.2.3