From 503e3833ef240c94e114be8703046d52f24da021 Mon Sep 17 00:00:00 2001 From: Peter Eisentraut Date: Wed, 13 Jul 2022 11:40:00 +0200 Subject: Remove useless assertions We don't need Assert(IsA(foo, String)) right before running strVal(foo), since strVal() already does the assertion internally (via castNode()). --- src/backend/executor/functions.c | 2 -- 1 file changed, 2 deletions(-) (limited to 'src/backend/executor') diff --git a/src/backend/executor/functions.c b/src/backend/executor/functions.c index f9460ae506c..076226868f3 100644 --- a/src/backend/executor/functions.c +++ b/src/backend/executor/functions.c @@ -318,12 +318,10 @@ sql_fn_post_column_ref(ParseState *pstate, ColumnRef *cref, Node *var) nnames--; field1 = (Node *) linitial(cref->fields); - Assert(IsA(field1, String)); name1 = strVal(field1); if (nnames > 1) { subfield = (Node *) lsecond(cref->fields); - Assert(IsA(subfield, String)); name2 = strVal(subfield); } -- cgit v1.2.3