From ec73b56a31fd0933280e85cd4e7b17c45c2ccbed Mon Sep 17 00:00:00 2001 From: Tom Lane Date: Sun, 3 Aug 2008 19:10:52 +0000 Subject: Make GROUP BY work properly for datatypes that only support hashing and not sorting. The infrastructure for this was all in place already; it's only necessary to fix the planner to not assume that sorting is always an available option. --- src/backend/parser/parse_clause.c | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) (limited to 'src/backend/parser/parse_clause.c') diff --git a/src/backend/parser/parse_clause.c b/src/backend/parser/parse_clause.c index 0a3b544b10e..76e59c82d6e 100644 --- a/src/backend/parser/parse_clause.c +++ b/src/backend/parser/parse_clause.c @@ -8,7 +8,7 @@ * * * IDENTIFICATION - * $PostgreSQL: pgsql/src/backend/parser/parse_clause.c,v 1.172 2008/08/02 21:32:00 tgl Exp $ + * $PostgreSQL: pgsql/src/backend/parser/parse_clause.c,v 1.173 2008/08/03 19:10:52 tgl Exp $ * *------------------------------------------------------------------------- */ @@ -1351,15 +1351,11 @@ transformGroupClause(ParseState *pstate, List *grouplist, /* * If no match in ORDER BY, just add it to the result using * default sort/group semantics. - * - * XXX for now, the planner requires groupClause to be sortable, - * so we have to insist on that here. */ if (!found) result = addTargetToGroupList(pstate, tle, result, *targetlist, - true, /* XXX for now */ - true); + false, true); } return result; -- cgit v1.2.3