From 503e3833ef240c94e114be8703046d52f24da021 Mon Sep 17 00:00:00 2001 From: Peter Eisentraut Date: Wed, 13 Jul 2022 11:40:00 +0200 Subject: Remove useless assertions We don't need Assert(IsA(foo, String)) right before running strVal(foo), since strVal() already does the assertion internally (via castNode()). --- src/backend/parser/parse_expr.c | 10 ---------- 1 file changed, 10 deletions(-) (limited to 'src/backend/parser/parse_expr.c') diff --git a/src/backend/parser/parse_expr.c b/src/backend/parser/parse_expr.c index 1dbdba93daa..b1cc6a382f1 100644 --- a/src/backend/parser/parse_expr.c +++ b/src/backend/parser/parse_expr.c @@ -631,7 +631,6 @@ transformColumnRef(ParseState *pstate, ColumnRef *cref) { Node *field1 = (Node *) linitial(cref->fields); - Assert(IsA(field1, String)); colname = strVal(field1); /* Try to identify as an unqualified column */ @@ -664,7 +663,6 @@ transformColumnRef(ParseState *pstate, ColumnRef *cref) Node *field1 = (Node *) linitial(cref->fields); Node *field2 = (Node *) lsecond(cref->fields); - Assert(IsA(field1, String)); relname = strVal(field1); /* Locate the referenced nsitem */ @@ -685,7 +683,6 @@ transformColumnRef(ParseState *pstate, ColumnRef *cref) break; } - Assert(IsA(field2, String)); colname = strVal(field2); /* Try to identify as a column of the nsitem */ @@ -712,9 +709,7 @@ transformColumnRef(ParseState *pstate, ColumnRef *cref) Node *field2 = (Node *) lsecond(cref->fields); Node *field3 = (Node *) lthird(cref->fields); - Assert(IsA(field1, String)); nspname = strVal(field1); - Assert(IsA(field2, String)); relname = strVal(field2); /* Locate the referenced nsitem */ @@ -735,7 +730,6 @@ transformColumnRef(ParseState *pstate, ColumnRef *cref) break; } - Assert(IsA(field3, String)); colname = strVal(field3); /* Try to identify as a column of the nsitem */ @@ -764,11 +758,8 @@ transformColumnRef(ParseState *pstate, ColumnRef *cref) Node *field4 = (Node *) lfourth(cref->fields); char *catname; - Assert(IsA(field1, String)); catname = strVal(field1); - Assert(IsA(field2, String)); nspname = strVal(field2); - Assert(IsA(field3, String)); relname = strVal(field3); /* @@ -798,7 +789,6 @@ transformColumnRef(ParseState *pstate, ColumnRef *cref) break; } - Assert(IsA(field4, String)); colname = strVal(field4); /* Try to identify as a column of the nsitem */ -- cgit v1.2.3