From bb4114a4e2c65f27931cc074214c051dba2876c3 Mon Sep 17 00:00:00 2001 From: Tom Lane Date: Wed, 25 Dec 2019 15:44:15 -0500 Subject: Allow whole-row Vars to be used in partitioning expressions. In the wake of commit 5b9312378, there's no particular reason for this restriction (previously, it was problematic because of the implied rowtype reference). A simple constraint on a whole-row Var probably isn't that useful, but conceivably somebody would want to pass one to a function that extracts a partitioning key. Besides which, we're expending much more code to enforce the restriction than we save by having it, since the latter quantity is now zero. So drop the restriction. Amit Langote Discussion: https://postgr.es/m/CA+HiwqFUzjfj9HEsJtYWcr1SgQ_=iCAvQ=O2Sx6aQxoDu4OiHw@mail.gmail.com --- src/backend/partitioning/partbounds.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'src/backend/partitioning/partbounds.c') diff --git a/src/backend/partitioning/partbounds.c b/src/backend/partitioning/partbounds.c index 4c6ca899fe8..4f7ac5bf829 100644 --- a/src/backend/partitioning/partbounds.c +++ b/src/backend/partitioning/partbounds.c @@ -1247,7 +1247,7 @@ check_default_partition_contents(Relation parent, Relation default_rel, */ def_part_constraints = map_partition_varattnos(def_part_constraints, 1, default_rel, - parent, NULL); + parent); /* * If the existing constraints on the default partition imply that it will @@ -1297,7 +1297,7 @@ check_default_partition_contents(Relation parent, Relation default_rel, partition_constraint = make_ands_explicit(def_part_constraints); partition_constraint = (Expr *) map_partition_varattnos((List *) partition_constraint, 1, - part_rel, default_rel, NULL); + part_rel, default_rel); /* * If the partition constraints on default partition child imply -- cgit v1.2.3