From 1609797c25f6b440371045039733d69fe8cb9410 Mon Sep 17 00:00:00 2001 From: Tom Lane Date: Sun, 4 Sep 2011 01:13:16 -0400 Subject: Clean up the #include mess a little. walsender.h should depend on xlog.h, not vice versa. (Actually, the inclusion was circular until a couple hours ago, which was even sillier; but Bruce broke it in the expedient rather than logically correct direction.) Because of that poor decision, plus blind application of pgrminclude, we had a situation where half the system was depending on xlog.h to include such unrelated stuff as array.h and guc.h. Clean up the header inclusion, and manually revert a lot of what pgrminclude had done so things build again. This episode reinforces my feeling that pgrminclude should not be run without adult supervision. Inclusion changes in header files in particular need to be reviewed with great care. More generally, it'd be good if we had a clearer notion of module layering to dictate which headers can sanely include which others ... but that's a big task for another day. --- src/backend/utils/adt/regexp.c | 1 + 1 file changed, 1 insertion(+) (limited to 'src/backend/utils/adt/regexp.c') diff --git a/src/backend/utils/adt/regexp.c b/src/backend/utils/adt/regexp.c index 61362c97e1b..70c8297b67c 100644 --- a/src/backend/utils/adt/regexp.c +++ b/src/backend/utils/adt/regexp.c @@ -32,6 +32,7 @@ #include "catalog/pg_type.h" #include "funcapi.h" #include "regex/regex.h" +#include "utils/array.h" #include "utils/builtins.h" #define PG_GETARG_TEXT_PP_IF_EXISTS(_n) \ -- cgit v1.2.3