From ed1ff84750e237af343c267b630c17624be49916 Mon Sep 17 00:00:00 2001 From: Tom Lane Date: Mon, 19 Nov 2001 19:51:20 +0000 Subject: Tweak format_type so that we get good behavior for both column type display (with a typemod) and function arg/result type display (without a typemod). --- src/backend/utils/adt/ruleutils.c | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-) (limited to 'src/backend/utils/adt/ruleutils.c') diff --git a/src/backend/utils/adt/ruleutils.c b/src/backend/utils/adt/ruleutils.c index 3ed36783f5c..03ea936b62e 100644 --- a/src/backend/utils/adt/ruleutils.c +++ b/src/backend/utils/adt/ruleutils.c @@ -3,7 +3,7 @@ * back to source text * * IDENTIFICATION - * $Header: /cvsroot/pgsql/src/backend/utils/adt/ruleutils.c,v 1.86 2001/10/25 05:49:45 momjian Exp $ + * $Header: /cvsroot/pgsql/src/backend/utils/adt/ruleutils.c,v 1.87 2001/11/19 19:51:20 tgl Exp $ * * This software is copyrighted by Jan Wieck - Hamburg. * @@ -2054,11 +2054,9 @@ get_func_expr(Expr *expr, deparse_context *context) /* * Show typename with appropriate length decoration. Note that * since exprIsLengthCoercion succeeded, the function's output - * type is the right thing to use. - * - * XXX In general it is incorrect to quote the result of - * format_type_with_typemod, but are there any special cases where - * we should do so? + * type is the right thing to report. Also note we don't need + * to quote the result of format_type_with_typemod: it takes + * care of double-quoting any identifier that needs it. */ typdesc = format_type_with_typemod(procStruct->prorettype, coercedTypmod); -- cgit v1.2.3