From 5094da99b901df42580b6e7494d036ee4be9eb81 Mon Sep 17 00:00:00 2001 From: Alvaro Herrera Date: Thu, 12 Nov 2015 18:05:23 -0300 Subject: vacuumdb: don't prompt for passwords over and over MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Having the script prompt for passwords over and over was a preexisting problem when it processed multiple databases or when it processed multiple analyze stages, but the parallel mode introduced in commit a179232047 made it worse. Fix the annoyance by keeping a copy of the password used by the first connection that requires one. Since users can (currently) only have a single password, there's no need for more complex arrangements (such as remembering one password per database). Per bug #13741 reported by Eric Brown. Patch authored and cross-reviewed by Haribabu Kommi and Michael Paquier, slightly tweaked by Álvaro Herrera. Discussion: http://www.postgresql.org/message-id/20151027193919.931.54948@wrigleys.postgresql.org Backpatch to 9.5, where parallel vacuumdb was introduced. --- src/bin/scripts/common.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'src/bin/scripts/common.h') diff --git a/src/bin/scripts/common.h b/src/bin/scripts/common.h index b5ce1ed7444..dafd58f4225 100644 --- a/src/bin/scripts/common.h +++ b/src/bin/scripts/common.h @@ -31,8 +31,8 @@ extern void handle_help_version_opts(int argc, char *argv[], extern PGconn *connectDatabase(const char *dbname, const char *pghost, const char *pgport, const char *pguser, - enum trivalue prompt_password, const char *progname, - bool fail_ok); + const char *pgpassword, enum trivalue prompt_password, + const char *progname, bool fail_ok); extern PGconn *connectMaintenanceDatabase(const char *maintenance_db, const char *pghost, const char *pgport, const char *pguser, -- cgit v1.2.3