From ae6d06f09684d8f8a7084514c9b35a274babca61 Mon Sep 17 00:00:00 2001 From: Michael Paquier Date: Thu, 6 Jul 2023 08:16:24 +0900 Subject: Handle \v as a whitespace character in parsers This commit comes as a continuation of the discussion that has led to d522b05, as \v was handled inconsistently when parsing array values or anything going through the parsers, and changing a parser behavior in stable branches is a scary thing to do. The parsing of array values now uses the more central scanner_isspace() and array_isspace() is removed. As pointing out by Peter Eisentraut, fix a confusing reference to horizontal space in the parsers with the term "horiz_space". \f was included in this set since 3cfdd8f from 2000, but it is not horizontal. "horiz_space" is renamed to "non_newline_space", to refer to all whitespace characters except newlines. The changes impact the parsers for the backend, psql, seg, cube, ecpg and replication commands. Note that JSON should not escape \v, as per RFC 7159, so these are not touched. Reviewed-by: Peter Eisentraut, Tom Lane Discussion: https://postgr.es/m/ZJKcjNwWHHvw9ksQ@paquier.xyz --- src/fe_utils/string_utils.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'src/fe_utils/string_utils.c') diff --git a/src/fe_utils/string_utils.c b/src/fe_utils/string_utils.c index 0429a72bfe2..58b21c4d6a8 100644 --- a/src/fe_utils/string_utils.c +++ b/src/fe_utils/string_utils.c @@ -761,7 +761,7 @@ appendPGArray(PQExpBuffer buffer, const char *value) if (ch == '"' || ch == '\\' || ch == '{' || ch == '}' || ch == ',' || - /* these match array_isspace(): */ + /* these match scanner_isspace(): */ ch == ' ' || ch == '\t' || ch == '\n' || ch == '\r' || ch == '\v' || ch == '\f') { -- cgit v1.2.3