From 9fac5fd741ec17ae24dde6b8e82064f13c148ddf Mon Sep 17 00:00:00 2001 From: Tom Lane Date: Sun, 15 Mar 2015 15:19:04 -0400 Subject: Move LockClauseStrength, LockWaitPolicy into new file nodes/lockoptions.h. Commit df630b0dd5ea2de52972d456f5978a012436115e moved enum LockWaitPolicy into its very own header file utils/lockwaitpolicy.h, which does not seem like a great idea from here. First, it's still a node-related declaration, and second, a file named like that can never sensibly be used for anything else. I do not think we want to encourage a one-typedef-per-header-file approach. The upcoming foreign table inheritance patch was doubling down on this bad idea by moving enum LockClauseStrength into its *own* can-never-be-used-for-anything-else file. Instead, let's put them both in a file named nodes/lockoptions.h. (They do seem to need a separate header file because we need them in both parsenodes.h and plannodes.h, and we don't want either of those including the other. Past practice might suggest adding them to nodes/nodes.h, but they don't seem sufficiently globally useful to justify that.) Committed separately since there's no functional change here, just some header-file refactoring. --- src/include/executor/executor.h | 1 - 1 file changed, 1 deletion(-) (limited to 'src/include/executor') diff --git a/src/include/executor/executor.h b/src/include/executor/executor.h index 40fde83a20b..c1e74779561 100644 --- a/src/include/executor/executor.h +++ b/src/include/executor/executor.h @@ -16,7 +16,6 @@ #include "executor/execdesc.h" #include "nodes/parsenodes.h" -#include "utils/lockwaitpolicy.h" /* -- cgit v1.2.3