From ac4494646daee27df20f7cded3ad49be24e9a98c Mon Sep 17 00:00:00 2001 From: Heikki Linnakangas Date: Wed, 12 Mar 2025 22:03:39 +0200 Subject: Rename alloc/free functions in reorderbuffer.c There used to be bespoken pools for these structs to reduce the palloc/pfree overhead, but that was ripped out a long time ago and replaced with the generic, cheaper generational memory allocator (commit a4ccc1cef5). The Get/Return terminology made sense with the pools, as you "got" an object from the pool and "returned" it later, but now it just looks weird. Rename to Alloc/Free. Reviewed-by: Tom Lane Discussion: https://www.postgresql.org/message-id/c9e43d2d-8e83-444f-b111-430377368989@iki.fi --- src/include/replication/reorderbuffer.h | 15 +++++++-------- 1 file changed, 7 insertions(+), 8 deletions(-) (limited to 'src/include/replication/reorderbuffer.h') diff --git a/src/include/replication/reorderbuffer.h b/src/include/replication/reorderbuffer.h index 517a8e3634f..3be0cbd7ebe 100644 --- a/src/include/replication/reorderbuffer.h +++ b/src/include/replication/reorderbuffer.h @@ -689,16 +689,15 @@ struct ReorderBuffer extern ReorderBuffer *ReorderBufferAllocate(void); extern void ReorderBufferFree(ReorderBuffer *rb); -extern HeapTuple ReorderBufferGetTupleBuf(ReorderBuffer *rb, - Size tuple_len); -extern void ReorderBufferReturnTupleBuf(HeapTuple tuple); +extern HeapTuple ReorderBufferAllocTupleBuf(ReorderBuffer *rb, Size tuple_len); +extern void ReorderBufferFreeTupleBuf(HeapTuple tuple); -extern ReorderBufferChange *ReorderBufferGetChange(ReorderBuffer *rb); -extern void ReorderBufferReturnChange(ReorderBuffer *rb, - ReorderBufferChange *change, bool upd_mem); +extern ReorderBufferChange *ReorderBufferAllocChange(ReorderBuffer *rb); +extern void ReorderBufferFreeChange(ReorderBuffer *rb, + ReorderBufferChange *change, bool upd_mem); -extern Oid *ReorderBufferGetRelids(ReorderBuffer *rb, int nrelids); -extern void ReorderBufferReturnRelids(ReorderBuffer *rb, Oid *relids); +extern Oid *ReorderBufferAllocRelids(ReorderBuffer *rb, int nrelids); +extern void ReorderBufferFreeRelids(ReorderBuffer *rb, Oid *relids); extern void ReorderBufferQueueChange(ReorderBuffer *rb, TransactionId xid, XLogRecPtr lsn, ReorderBufferChange *change, -- cgit v1.2.3