From 41f18f021a0882eccbeca62e2ed4b66c6b96e9c9 Mon Sep 17 00:00:00 2001 From: Noah Misch Date: Mon, 8 Aug 2016 10:07:46 -0400 Subject: Promote pg_dumpall shell/connstr quoting functions to src/fe_utils. Rename these newly-extern functions with terms more typical of their new neighbors. No functional changes; a subsequent commit will use them in more places. Back-patch to 9.1 (all supported versions). Back branches lack src/fe_utils, so instead rename the functions in place; the subsequent commit will copy them into the other programs using them. Security: CVE-2016-5424 --- src/port/system.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) (limited to 'src/port/system.c') diff --git a/src/port/system.c b/src/port/system.c index f685a4e0b2d..b0f98efae62 100644 --- a/src/port/system.c +++ b/src/port/system.c @@ -7,7 +7,8 @@ * Win32 needs double quotes at the beginning and end of system() * strings. If not, it gets confused with multiple quoted strings. * It also requires double-quotes around the executable name and - * any files used for redirection. Other args can use single-quotes. + * any files used for redirection. Filter other args through + * appendShellString() to quote them. * * Generated using Win32 "CMD /?": * -- cgit v1.2.3