From 2e8ce9ae46d15b2bfd34c2d53193da9858d3471a Mon Sep 17 00:00:00 2001 From: Tom Lane Date: Tue, 1 Jul 2014 17:51:53 -0400 Subject: Remove some useless code in the configure script. Almost ten years ago, commit e48322a6d6cfce1ec52ab303441df329ddbc04d1 broke the logic in ACX_PTHREAD by looping through all the possible flags rather than stopping with the first one that would work. This meant that $acx_pthread_ok was no longer meaningful after the loop; it would usually be "no", whether or not we'd found working thread flags. The reason nobody noticed is that Postgres doesn't actually use any of the symbols set up by the code after the loop. Rather than complicate things some more to make it work as designed, let's just remove all that dead code, and thereby save a few cycles in each configure run. --- src/include/pg_config.h.in | 7 ------- src/include/pg_config.h.win32 | 7 ------- 2 files changed, 14 deletions(-) (limited to 'src') diff --git a/src/include/pg_config.h.in b/src/include/pg_config.h.in index 4fb7288710d..2a40d6140bd 100644 --- a/src/include/pg_config.h.in +++ b/src/include/pg_config.h.in @@ -369,9 +369,6 @@ /* Define to 1 if the PS_STRINGS thing exists. */ #undef HAVE_PS_STRINGS -/* Define if you have POSIX threads libraries and header files. */ -#undef HAVE_PTHREAD - /* Define to 1 if you have the header file. */ #undef HAVE_PWD_H @@ -710,10 +707,6 @@ process. */ #undef PROFILE_PID_DIR -/* Define to the necessary symbol if this constant uses a non-standard name on - your system. */ -#undef PTHREAD_CREATE_JOINABLE - /* RELSEG_SIZE is the maximum number of blocks allowed in one disk file. Thus, the maximum size of a single file is RELSEG_SIZE * BLCKSZ; relations bigger than that are divided into multiple files. RELSEG_SIZE * BLCKSZ must be diff --git a/src/include/pg_config.h.win32 b/src/include/pg_config.h.win32 index 30a9a6ae0b8..1c9cd82b838 100644 --- a/src/include/pg_config.h.win32 +++ b/src/include/pg_config.h.win32 @@ -276,9 +276,6 @@ /* Define to 1 if the PS_STRINGS thing exists. */ /* #undef HAVE_PS_STRINGS */ -/* Define if you have POSIX threads libraries and header files. */ -/* #undef HAVE_PTHREAD */ - /* Define to 1 if you have the header file. */ #define HAVE_PWD_H 1 @@ -578,10 +575,6 @@ /* A string containing the version number, platform, and C compiler */ #define PG_VERSION_STR "Uninitialized version string (win32)" -/* Define to the necessary symbol if this constant uses a non-standard name on - your system. */ -/* #undef PTHREAD_CREATE_JOINABLE */ - /* The size of `long', as computed by sizeof. */ #define SIZEOF_LONG 4 -- cgit v1.2.3