]> git.kaiwu.me - njs.git/commitdiff
Fixed http response and parent getters.
authorDmitry Volyntsev <xeioex@nginx.com>
Thu, 27 Sep 2018 14:37:55 +0000 (17:37 +0300)
committerDmitry Volyntsev <xeioex@nginx.com>
Thu, 27 Sep 2018 14:37:55 +0000 (17:37 +0300)
Getters are expected to set resulting value to the provided
argument, not to vm->retval.

nginx/ngx_http_js_module.c

index 7624d438271dbbc1e72d2172ff442df08778fc5d..3121bad3e1a9c8f452a4e62d48670c1762f71a9b 100644 (file)
@@ -1844,7 +1844,7 @@ ngx_http_js_ext_get_response(njs_vm_t *vm, njs_value_t *value, void *obj,
 
     ctx = ngx_http_get_module_ctx(r, ngx_http_js_module);
 
-    njs_vm_retval_set(vm, njs_value_arg(&ctx->args[1]));
+    njs_value_assign(value, njs_value_arg(&ctx->args[1]));
 
     return NJS_OK;
 }
@@ -2189,7 +2189,7 @@ ngx_http_js_ext_get_parent(njs_vm_t *vm, njs_value_t *value, void *obj,
         return NJS_ERROR;
     }
 
-    njs_vm_retval_set(vm, njs_value_arg(&ctx->args[0]));
+    njs_value_assign(value, njs_value_arg(&ctx->args[0]));
 
     return NJS_OK;
 }