CI: github: cache VTest binary in FreeBSD workflow

The FreeBSD job rebuilds VTest2 from source on every run. The shared
setup-vtest action cannot be used directly because it runs on the Ubuntu
host and would produce a Linux binary rather than a FreeBSD one.

Restore and save the workspace-relative vtest directory on the host with
actions/cache. Build into that directory inside the guest and explicitly
enable copyback so the resulting FreeBSD binary is available to the save
step after the VM exits.

Use the same release and architecture variables for the VM and cache key.
Keep the FreeBSD namespace separate from other jobs, and include the
upstream VTest SHA, build-script hash and a manual version suffix to
invalidate incompatible entries. Skip both cache steps if the SHA lookup
returns no output.

Probe the cached binary with -V and rebuild if it is missing or unusable.
Print the selected version and pass its absolute path to the full
regression suite. Save only after the VM step succeeds and the restore
was not an exact hit; retain the existing build and failure diagnostics.

diff --git a/.github/workflows/freebsd.yml b/.github/workflows/freebsd.yml
index 38b1f78193aafde205b12fbf1c59b5a18d8270aa..3099ceb0077a77ab8e3e279a7050891f99f6bb58 100644 (file)
--- a/.github/workflows/freebsd.yml
+++ b/.github/workflows/freebsd.yml
@@ -11,25 +11,57 @@ jobs:
   clang:
     runs-on: ubuntu-latest
     if: ${{ github.repository_owner == 'haproxy' || github.event_name == 'workflow_dispatch' }}
+    env:
+      FREEBSD_RELEASE: "14.4"
+      FREEBSD_ARCH: "x86_64"
     steps:
       - name: "Checkout repository"
         uses: actions/checkout@v6
 
+      - name: "Get VTest latest commit SHA"
+        id: vtest-sha
+        shell: sh
+        run: |
+          sha=$(git ls-remote https://code.vinyl-cache.org/vtest/VTest2 HEAD | cut -f1)
+          if [ -n "${sha}" ]; then
+            echo "sha=${sha}" >> "$GITHUB_OUTPUT"
+          fi
+
+      - name: "Restore VTest cache"
+        id: cache-vtest
+        if: ${{ steps.vtest-sha.outputs.sha != '' }}
+        uses: actions/cache/restore@v5
+        with:
+          path: vtest
+          key: vtest-freebsd-${{ env.FREEBSD_RELEASE }}-${{ env.FREEBSD_ARCH }}-v1-${{ steps.vtest-sha.outputs.sha }}-${{ hashFiles('scripts/build-vtest.sh') }}
+
       - name: "Build and test on FreeBSD"
         uses: vmactions/freebsd-vm@v1
         with:
-          release: "14.4"
+          release: ${{ env.FREEBSD_RELEASE }}
+          arch: ${{ env.FREEBSD_ARCH }}
+          copyback: true
           prepare: |
             pkg update -f && pkg upgrade -y && pkg install -y openssl git gmake lua54 socat pcre2 python3
           run: |
             sysctl kern.corefile=/tmp/%N.%P.core
             sysctl kern.sugid_coredump=1
-            scripts/build-vtest.sh
+            if ! "${GITHUB_WORKSPACE}/vtest/vtest" -V >/dev/null 2>&1; then
+              DESTDIR="${GITHUB_WORKSPACE}/vtest" scripts/build-vtest.sh
+            fi
+            "${GITHUB_WORKSPACE}/vtest/vtest" -V
             gmake CC=clang V=1 ERR=1 TARGET=freebsd USE_ZLIB=1 USE_PCRE2=1 USE_PCRE2_JIT=1 USE_OPENSSL=1 USE_LUA=1 LUA_INC=/usr/local/include/lua54 LUA_LIB=/usr/local/lib LUA_LIB_NAME=lua-5.4
             ./haproxy -vv
             ldd haproxy
-            if ! env VTEST_PROGRAM=../vtest/vtest gmake reg-tests REGTESTS_TYPES=default,bug,devel; then
+            if ! env VTEST_PROGRAM="${GITHUB_WORKSPACE}/vtest/vtest" gmake reg-tests REGTESTS_TYPES=default,bug,devel; then
               for folder in /tmp/*regtest*/vtc.*; do cat $folder/INFO $folder/LOG; done
               ls /tmp/haproxy.*.core 2>/dev/null && gdb -ex 'thread apply all bt full' ./haproxy /tmp/haproxy.*.core
               exit 1
             fi
+
+      - name: "Save VTest cache"
+        if: ${{ steps.vtest-sha.outputs.sha != '' && steps.cache-vtest.outputs.cache-hit != 'true' }}
+        uses: actions/cache/save@v5
+        with:
+          path: vtest
+          key: ${{ steps.cache-vtest.outputs.cache-primary-key }}