From 54b6c4a35361c38f82d10686fe3f1c8e1672e33d Mon Sep 17 00:00:00 2001 From: Frederic Lecaille Date: Thu, 29 Oct 2026 15:20:21 +0100 Subject: [PATCH] CLEANUP: quic: remove the unused count and flags from struct quic_tls_kp The count and flags members of struct quic_tls_kp are only initialized by quic_tls_kp_init() and read nowhere: the key phase state is kept in the pn member of the TLS secrets and in the flags member of the TLS context. Let's remove them. --- include/haproxy/quic_tls-t.h | 2 -- include/haproxy/quic_tls.h | 2 -- 2 files changed, 4 deletions(-) diff --git a/include/haproxy/quic_tls-t.h b/include/haproxy/quic_tls-t.h index 52f07e88f..48f4e98b3 100644 --- a/include/haproxy/quic_tls-t.h +++ b/include/haproxy/quic_tls-t.h @@ -204,8 +204,6 @@ struct quic_tls_kp { size_t ivlen; unsigned char *key; size_t keylen; - uint64_t count; - unsigned char flags; }; /* Key phase bit of the packets we send */ diff --git a/include/haproxy/quic_tls.h b/include/haproxy/quic_tls.h index a4d223722..61d9f532b 100644 --- a/include/haproxy/quic_tls.h +++ b/include/haproxy/quic_tls.h @@ -1170,8 +1170,6 @@ static inline void quic_tls_ku_free(struct quic_conn *qc) */ static inline int quic_tls_kp_init(struct quic_tls_kp *kp) { - kp->count = 0; - kp->flags = 0; kp->secret = pool_alloc(pool_head_quic_tls_secret); kp->secretlen = QUIC_TLS_SECRET_LEN; kp->iv = pool_alloc(pool_head_quic_tls_iv); -- 2.47.3