From: Dmitry Volyntsev Date: Mon, 16 Nov 2026 23:33:44 +0000 (-0800) Subject: WebCrypto: transfer imported key ownership X-Git-Url: https://git.kaiwu.me/%7Bsubstring-before(@doc,%20'.xml')%7D.html?a=commitdiff_plain;h=c480b99302e0b3062f8dec7ad9ad3c355cf4a040;p=njs.git WebCrypto: transfer imported key ownership Previously, failure to allocate the external CryptoKey object freed an imported EVP_PKEY in the local error handler, then freed it again when the VM memory pool ran the key cleanup. Clear the local pointer when ownership passes to the key cleanup. The issue was introduced in 50e7c9b2 (0.7.10). --- diff --git a/external/njs_webcrypto_module.c b/external/njs_webcrypto_module.c index dbccf2e9..96bd1612 100644 --- a/external/njs_webcrypto_module.c +++ b/external/njs_webcrypto_module.c @@ -4144,6 +4144,7 @@ njs_webcrypto_import_key_internal(njs_vm_t *vm, njs_webcrypto_key_format_t fmt, key->hash = hash; key->u.a.pkey = pkey; + pkey = NULL; break; @@ -4213,6 +4214,7 @@ njs_webcrypto_import_key_internal(njs_vm_t *vm, njs_webcrypto_key_format_t fmt, } key->u.a.pkey = pkey; + pkey = NULL; break; @@ -4241,6 +4243,7 @@ njs_webcrypto_import_key_internal(njs_vm_t *vm, njs_webcrypto_key_format_t fmt, } key->u.a.pkey = pkey; + pkey = NULL; break; @@ -4273,6 +4276,7 @@ njs_webcrypto_import_key_internal(njs_vm_t *vm, njs_webcrypto_key_format_t fmt, } key->u.a.pkey = pkey; + pkey = NULL; break; #endif