BUG/MINOR: sample: Fix wrong 'base64urldec' return value check in 'jwt_member_query'

The 'base64urldec' function return value was only checked against -1
when it can also return -2 in case of error (too small out buffer).

This was raised in GitHub issue #3510.
This patch can be backported to all stable branches.

diff --git a/src/sample.c b/src/sample.c
index c34f143a8e0b102f03b1112a367bb188c7e88798..7f2a93df6f2372391b9251aab089402ebdf4e7ba 100644 (file)
--- a/src/sample.c
+++ b/src/sample.c
@@ -5072,7 +5072,7 @@ static int sample_conv_jwt_member_query(const struct arg *args, struct sample *s
 
        ret = base64urldec(items[member].start, items[member].length,
                           decoded_header->area, decoded_header->size);
-       if (ret == -1)
+       if (ret < 0)
                goto end;
 
        /* mjson might return an embedded \0 that is not valid as a string */