]> git.kaiwu.me - haproxy.git/commitdiff
CLEANUP: quic: remove duplicated key phase pointer assignments
authorFrederic Lecaille <flecaille@haproxy.com>
Thu, 29 Oct 2026 10:44:51 +0000 (11:44 +0100)
committerFrederic Lecaille <flecaille@haproxy.com>
Tue, 3 Nov 2026 06:56:46 +0000 (07:56 +0100)
<nxt_rx> and <nxt_tx> are already initialized from <qc->ku> at
declaration time in <quic_tls_key_update()>, and <qc->ku> is not
modified in between, so the two assignments placed after TRACE_ENTER()
are dead duplicates.

src/quic_tls.c

index 9f1726c25a6715c210a6b44ec30ede220717e453..10d7e7ade097c77a747f5bf67e13f414578d2d6e 100644 (file)
@@ -1088,9 +1088,6 @@ int quic_tls_key_update(struct quic_conn *qc)
 
        TRACE_ENTER(QUIC_EV_CONN_KP, qc);
 
-       nxt_rx = &qc->ku.nxt_rx;
-       nxt_tx = &qc->ku.nxt_tx;
-
        TRACE_PRINTF(TRACE_LEVEL_DEVELOPER, QUIC_EV_CONN_SPPKTS, qc, 0, 0, 0,
                     "nxt_rx->secretlen=%llu rx->secretlen=%llu",
                     (ull)nxt_rx->secretlen, (ull)rx->secretlen);