]> git.kaiwu.me - haproxy.git/commitdiff
BUILD: haring: fix compile issue due to nop warning.
authorEmeric Brun <ebrun@haproxy.com>
Mon, 28 Sep 2026 13:22:50 +0000 (15:22 +0200)
committerWilly Tarreau <w@1wt.eu>
Tue, 29 Sep 2026 08:51:27 +0000 (10:51 +0200)
Compile issue introduced by commit c0b39ea75e ("DEV: haring: bound the
ring geometry to the size of the file").

This patch introduce a warning at compile the binary is not
compiling in case of -Wno-error because of statement with no effects.

In addition it seems also an error since the added static var was never set.

It seems to use a static to rise an error message only one time. So I
suppose it should be set to 1 as soon the error message is printed.

This patch must backported until 3.4.

dev/haring/haring.c

index 73e1676c22da87434532c70a12bb98e70af73bb8..acba4788a128547ffb4bc010359560d434e9ef65 100644 (file)
@@ -176,7 +176,7 @@ int dump_ring_as_buf(struct buffer buf, size_t ofs, int flags)
                                        fprintf(stderr, "Note: incomplete message at offset %llu, dumping "
                                                "its first %llu byte(s) and stopping.\n",
                                                (unsigned long long)ofs, (unsigned long long)msg_len);
-                                       warned;
+                                       warned = 1;
                                }
                                truncated = 1;
                        }