From: Olivier Houchard <ohouchard@haproxy.com>
Date: Wed, 19 Aug 2026 14:16:20 +0000 (+0200)
Subject: MINOR: addons/deviceatlas: Forbid use with per tgroup fd tables
X-Git-Tag: v3.5-dev5~2
X-Git-Url: https://git.kaiwu.me/?a=commitdiff_plain;h=0bcd3f83af03b45ae203c36e8af26486a0f4154b;p=haproxy.git

MINOR: addons/deviceatlas: Forbid use with per tgroup fd tables

It is not known if deviceatlas uses its own file descriptors, so for the time
being, forbid its usage with tune.fd.tables per-thread-group.
---

diff --git a/addons/deviceatlas/da.c b/addons/deviceatlas/da.c
index 552d3a95c..55429a7c5 100644
--- a/addons/deviceatlas/da.c
+++ b/addons/deviceatlas/da.c
@@ -176,6 +176,12 @@ static int init_deviceatlas(void)
 		size_t atlasimglen;
 		da_status_t status;
 
+		if ((global.tune.options & GTUNE_NO_TG_FD_SHARING) &&
+		    global.nbtgroups > 1) {
+			ha_alert("deviceatlas is incompatible with tune.fd.tables per-thread-group\n");
+			err_code |= ERR_ALERT | ERR_FATAL;
+			goto out;
+		}
 		jsonp = fopen(global_deviceatlas.jsonpath, "r");
 		if (unlikely(jsonp == 0)) {
 			ha_alert("deviceatlas : '%s' json file has invalid path or is not readable.\n",