From: William Lallemand <wlallemand@haproxy.com>
Date: Tue, 18 Aug 2026 14:27:34 +0000 (+0000)
Subject: CLEANUP: payload: remove dead code in smp_client_hello_parse()
X-Git-Tag: v3.5-dev5~14
X-Git-Url: https://git.kaiwu.me/?a=commitdiff_plain;h=489163624c2e8f929d9eb86998aad978e68dc0d3;p=haproxy.git

CLEANUP: payload: remove dead code in smp_client_hello_parse()

Remove dead code reported by Coverity (CID 1660132, GH #3471). bleft
is already guaranteed to be >= hs_len >= 49 by the two preceding
checks (bleft < 5 / hs_len < 49 / bleft < hs_len), so the
`if (bleft < 1)` check right after can never be true.
---

diff --git a/src/payload.c b/src/payload.c
index 8e1df72cf..fe88fea9b 100644
--- a/src/payload.c
+++ b/src/payload.c
@@ -120,8 +120,6 @@ smp_client_hello_parse( struct sample *smp, enum client_hello_type type, unsigne
 		goto too_short;
 
 	/* Check for a complete client hello starting at <data> */
-	if (bleft < 1)
-		goto too_short;
 	if (data[0] != 0x01) /* msg_type = Client Hello */
 		goto not_ssl_hello;