Previously, importKey() accepted an empty raw or JWK HMAC key. The
HMAC import key operation requires a DataError when the key data
length is zero. It is reported as TypeError, as other invalid key
data in njs.
The issue was introduced in
7b2b7612 (0.7.0) and the QuickJS
counterpart in
75ca26f8 (0.8.10).
+ if (key->u.s.raw.length == 0) {
+ njs_vm_type_error(vm, "HMAC key cannot be empty");
+ goto fail;
+ }
+
break;
case NJS_ALGORITHM_AES_GCM:
break;
case NJS_ALGORITHM_AES_GCM:
+ if (wkey->u.s.raw.length == 0) {
+ JS_ThrowTypeError(cx, "HMAC key cannot be empty");
+ goto fail;
+ }
+
break;
case QJS_ALGORITHM_AES_GCM:
break;
case QJS_ALGORITHM_AES_GCM:
extractable: true,
usage: [ "sign", "verify" ] },
exception: "TypeError: unknown hash name: \"SHA-385\"" },
extractable: true,
usage: [ "sign", "verify" ] },
exception: "TypeError: unknown hash name: \"SHA-385\"" },
+ { key: { fmt: "raw",
+ key: "",
+ alg: { name: "HMAC", hash: "SHA-256" },
+ extractable: true,
+ usage: [ "sign", "verify" ] },
+ exception: "TypeError: HMAC key cannot be empty" },
{ key: { fmt: "spki",
key: "ec.spki",
alg: { name: "HMAC" },
{ key: { fmt: "spki",
key: "ec.spki",
alg: { name: "HMAC" },
extractable: true,
usage: [ "sign" ]},
exception: "TypeError: Invalid JWK oct key" },
extractable: true,
usage: [ "sign" ]},
exception: "TypeError: Invalid JWK oct key" },
+ { key: { fmt: "jwk",
+ key: { alg: 'HS256', ext: true, k: '', kty: 'oct' },
+ alg: { name: "HMAC", hash: "SHA-256" },
+ extractable: true,
+ usage: [ "sign" ]},
+ exception: "TypeError: HMAC key cannot be empty" },
{ key: { fmt: "jwk",
key: { alg: 'HS256', k: 'AA', key_ops: [ 'sign' ], kty: 'oct' },
alg: { name: "HMAC", hash: "SHA-256" },
{ key: { fmt: "jwk",
key: { alg: 'HS256', k: 'AA', key_ops: [ 'sign' ], kty: 'oct' },
alg: { name: "HMAC", hash: "SHA-256" },