Previously, an HTTP/2 connection could be reusable while having streams.
This could result in an attempt to drain the connection while processing
one if its streams, for example when connecting to an upstream. After
recognizing that the connection has streams, an attempt to send the
GOAWAY frame was made. On send failure, the connection was immediately
closed and its pool released. This triggered a use-after-free up the
stack.
Having an HTTP/2 connection with streams registered as reusable became
possible after
76672e650. A connection with no streams and a partial
frame read from client was registered as reusable to avoid DoS attacks.
So if a client sends only the first HEADERS frame byte, the connection
becomes reusable. Later, when the remaining HEADERS bytes are received
and a new stream is created, the reusable status is not reset until the
connection becomes idle.
Fix is to mark the connection non-reusable upon stream creation.
Reported by Albert @ Vexera AI.