From: Amaury Denoyelle Date: Fri, 13 Nov 2026 09:47:56 +0000 (+0100) Subject: BUG/MINOR: qmux: remove invalid BUG_ON() on empty record X-Git-Url: https://git.kaiwu.me/web/upload.html?a=commitdiff_plain;h=429ca30e1b0d8a400761bd057a3943acc674d3f8;p=haproxy.git BUG/MINOR: qmux: remove invalid BUG_ON() on empty record In QMux, a BUG_ON() was present in receive path to report about a realign needed but not implemented. This is not necessary anymore as realign is now implemented. Worst, BUG_ON() could be triggered when receiving an empty record. Such records are not (yet?) prohibited by the spec. Simply remove the BUG_ON() to avoid any issue with it. This must be backported up to 3.4. --- diff --git a/src/qcm_qmux.c b/src/qcm_qmux.c index 4491fb726..2a8cdb9e0 100644 --- a/src/qcm_qmux.c +++ b/src/qcm_qmux.c @@ -188,9 +188,6 @@ int qcc_qmux_recv(struct qcc *qcc) } } - /* TODO realign necessary if record boundary at the extreme end of the buffer */ - BUG_ON(!qcc->rx.rlen && b_data(buf) && b_tail(buf) == b_orig(buf)); - while (qcc->rx.rlen && b_data(buf) >= qcc->rx.rlen) { buf_rec = b_make(b_orig(buf), b_size(buf), b_head_ofs(buf), qcc->rx.rlen);