diff options
| author | Maxim Dounin <mdounin@mdounin.ru> | 2023-05-21 04:38:45 +0300 |
|---|---|---|
| committer | Maxim Dounin <mdounin@mdounin.ru> | 2023-05-21 04:38:45 +0300 |
| commit | 0400e3d5cea76e4b99cb7ff593404286c463cc82 (patch) | |
| tree | 69eab6e9539035e0937f2e9223aee99aac80b7ca | |
| parent | 4b0266174814e6cf60a275321121dbaab084ee64 (diff) | |
| download | nginx-0400e3d5cea76e4b99cb7ff593404286c463cc82.tar.gz nginx-0400e3d5cea76e4b99cb7ff593404286c463cc82.zip | |
QUIC: better sockaddr initialization.
The qsock->sockaddr field is a ngx_sockaddr_t union, and therefore can hold
any sockaddr (and union members, such qsock->sockaddr.sockaddr, can be used
to access appropriate variant of the sockaddr). It is better to set it via
qsock->sockaddr itself though, and not qsock->sockaddr.sockaddr, so static
analyzers won't complain about out-of-bounds access.
Prodded by Coverity (CID 1530403).
| -rw-r--r-- | src/event/quic/ngx_event_quic_udp.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/event/quic/ngx_event_quic_udp.c b/src/event/quic/ngx_event_quic_udp.c index 71754a48b..15b54bc82 100644 --- a/src/event/quic/ngx_event_quic_udp.c +++ b/src/event/quic/ngx_event_quic_udp.c @@ -183,7 +183,7 @@ ngx_quic_recvmsg(ngx_event_t *ev) qsock = ngx_quic_get_socket(c); - ngx_memcpy(&qsock->sockaddr.sockaddr, sockaddr, socklen); + ngx_memcpy(&qsock->sockaddr, sockaddr, socklen); qsock->socklen = socklen; c->udp->buffer = &buf; |