aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorRoman Arutyunyan <arut@nginx.com>2022-11-30 14:09:08 +0400
committerRoman Arutyunyan <arut@nginx.com>2022-11-30 14:09:08 +0400
commit7e3aa23991cbab236617f15ab3602c1b43b2aae1 (patch)
tree7d6c4a186bf565f6559fb596fbfebff4ba903d09
parentfed44881d3bf5126b49144dba58f2830e0fe9866 (diff)
downloadnginx-7e3aa23991cbab236617f15ab3602c1b43b2aae1.tar.gz
nginx-7e3aa23991cbab236617f15ab3602c1b43b2aae1.zip
QUIC: removed cancelable flag from QUIC and HTTP/3 events.
All these events are created in context of a client connection and are deleted when the connection is closed. Setting ev->cancelable could trigger premature connection closure and a socket leak alert.
-rw-r--r--src/event/quic/ngx_event_quic.c4
-rw-r--r--src/http/v3/ngx_http_v3.c1
2 files changed, 0 insertions, 5 deletions
diff --git a/src/event/quic/ngx_event_quic.c b/src/event/quic/ngx_event_quic.c
index a28f5a7ac..9b342d7de 100644
--- a/src/event/quic/ngx_event_quic.c
+++ b/src/event/quic/ngx_event_quic.c
@@ -275,22 +275,18 @@ ngx_quic_new_connection(ngx_connection_t *c, ngx_quic_conf_t *conf,
qc->pto.log = c->log;
qc->pto.data = c;
qc->pto.handler = ngx_quic_pto_handler;
- qc->pto.cancelable = 1;
qc->push.log = c->log;
qc->push.data = c;
qc->push.handler = ngx_quic_push_handler;
- qc->push.cancelable = 1;
qc->close.log = c->log;
qc->close.data = c;
qc->close.handler = ngx_quic_close_handler;
- qc->close.cancelable = 1;
qc->path_validation.log = c->log;
qc->path_validation.data = c;
qc->path_validation.handler = ngx_quic_path_validation_handler;
- qc->path_validation.cancelable = 1;
qc->conf = conf;
diff --git a/src/http/v3/ngx_http_v3.c b/src/http/v3/ngx_http_v3.c
index b9956e68f..70f397985 100644
--- a/src/http/v3/ngx_http_v3.c
+++ b/src/http/v3/ngx_http_v3.c
@@ -55,7 +55,6 @@ ngx_http_v3_init_session(ngx_connection_t *c)
h3c->keepalive.log = pc->log;
h3c->keepalive.data = pc;
h3c->keepalive.handler = ngx_http_v3_keepalive_handler;
- h3c->keepalive.cancelable = 1;
h3c->table.send_insert_count.log = pc->log;
h3c->table.send_insert_count.data = pc;