diff options
author | Maxim Dounin <mdounin@mdounin.ru> | 2014-05-21 21:56:20 +0400 |
---|---|---|
committer | Maxim Dounin <mdounin@mdounin.ru> | 2014-05-21 21:56:20 +0400 |
commit | ca02a1020c41cc771d4ed6f854213edf594b4480 (patch) | |
tree | fb4f2a50f9d4253686577075a4c9a244f651c684 | |
parent | 493b898ae94ae7dd390d77c42f5500974be48393 (diff) | |
download | nginx-ca02a1020c41cc771d4ed6f854213edf594b4480.tar.gz nginx-ca02a1020c41cc771d4ed6f854213edf594b4480.zip |
Mail: added a check for the number of arguments in MAIL/RCPT.
Missed during introduction of the SMTP pipelining support (04e43d03e153,
1.5.6). Previously, the check wasn't needed as s->buffer was used directly
and the number of arguments didn't matter.
Reported by Svyatoslav Nikolsky.
-rw-r--r-- | src/mail/ngx_mail_smtp_handler.c | 10 |
1 files changed, 10 insertions, 0 deletions
diff --git a/src/mail/ngx_mail_smtp_handler.c b/src/mail/ngx_mail_smtp_handler.c index 52fe47523..665f5ef19 100644 --- a/src/mail/ngx_mail_smtp_handler.c +++ b/src/mail/ngx_mail_smtp_handler.c @@ -679,6 +679,11 @@ ngx_mail_smtp_mail(ngx_mail_session_t *s, ngx_connection_t *c) return NGX_OK; } + if (s->args.nelts == 0) { + ngx_str_set(&s->out, smtp_invalid_argument); + return NGX_OK; + } + arg = s->args.elts; arg += s->args.nelts - 1; @@ -713,6 +718,11 @@ ngx_mail_smtp_rcpt(ngx_mail_session_t *s, ngx_connection_t *c) return NGX_OK; } + if (s->args.nelts == 0) { + ngx_str_set(&s->out, smtp_invalid_argument); + return NGX_OK; + } + arg = s->args.elts; arg += s->args.nelts - 1; |