aboutsummaryrefslogtreecommitdiff
path: root/src
diff options
context:
space:
mode:
authorSergey Kandaurov <pluknet@nginx.com>2020-08-18 23:33:40 +0300
committerSergey Kandaurov <pluknet@nginx.com>2020-08-18 23:33:40 +0300
commit160242dd2e8544f21056056ce1b36b209bfaea63 (patch)
treef3eaf7c220a8dab4ef9bed53498876f221cc55d9 /src
parent9a0fb643bfcea20f8a3ede222f9a1d8ec234a2cd (diff)
downloadnginx-160242dd2e8544f21056056ce1b36b209bfaea63.tar.gz
nginx-160242dd2e8544f21056056ce1b36b209bfaea63.zip
QUIC: changed ctx->largest_ack initial value to type maximum.
In particular, this prevents declaring packet number 0 as lost if there aren't yet any acknowledgements in this packet number space. For example, only Initial packets were acknowledged in handshake.
Diffstat (limited to 'src')
-rw-r--r--src/event/ngx_event_quic.c3
1 files changed, 2 insertions, 1 deletions
diff --git a/src/event/ngx_event_quic.c b/src/event/ngx_event_quic.c
index 42650ab1a..94097c4d9 100644
--- a/src/event/ngx_event_quic.c
+++ b/src/event/ngx_event_quic.c
@@ -690,6 +690,7 @@ ngx_quic_new_connection(ngx_connection_t *c, ngx_ssl_t *ssl,
ngx_queue_init(&qc->send_ctx[i].frames);
ngx_queue_init(&qc->send_ctx[i].sent);
qc->send_ctx[i].largest_pn = (uint64_t) -1;
+ qc->send_ctx[i].largest_ack = (uint64_t) -1;
}
for (i = 0; i < NGX_QUIC_ENCRYPTION_LAST; i++) {
@@ -2346,7 +2347,7 @@ ngx_quic_handle_ack_frame(ngx_connection_t *c, ngx_quic_header_t *pkt,
}
/* 13.2.3. Receiver Tracking of ACK Frames */
- if (ctx->largest_ack < max) {
+ if (ctx->largest_ack < max || ctx->largest_ack == (uint64_t) -1) {
ctx->largest_ack = max;
ngx_log_debug1(NGX_LOG_DEBUG_EVENT, c->log, 0,
"quic updated largest received ack: %uL", max);