blob: f937a65d0c9f11b2642ba1ae998711ad7fd5ea66 (
plain)
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
|
=encoding utf-8
=head1 Name
contributing_changes - Contributing Changes
=head1 Getting Sources
L<GitHub|https://github.com> is used
to store source code.
The L<repository|https://github.com/nginx/nginx> can be cloned
with the following command:
git clone https://github.com/nginx/nginx.git
=head1 Formatting Changes
Changes should be formatted according to the
L<code style|development_guide>
used by nginx.
Sometimes, there is no clear rule; in such cases
examine how existing nginx sources are formatted and mimic this style.
Changes will more likely be accepted if style corresponds to the surrounding
code.
L<Commit|https://docs.github.com/en/pull-requests/committing-changes-to-your-project/creating-and-editing-commits/about-commits>
the changes in your nginx GitHub fork.
Please ensure that the specified
L<e-mail|https://docs.github.com/en/get-started/getting-started-with-git/setting-your-username-in-git>
address and real name of the author are correct.
The commit message should have a single-line synopsis followed by verbose
description after an empty line.
It is desirable that the first line is no longer than 67 symbols,
and the remaining lines are no longer than 76 symbols.
The resulting commit can be obtained using the
C<git show> command:
commit 8597218f386351d6c6cdced24af6716e19a18fc3
Author: Filipe Da Silva <username@example.com>
Date: Thu May 9 10:54:28 2013 +0200
Mail: removed surplus ngx_close_connection() call.
It is already called for a peer connection a few lines above.
diff --git a/src/mail/ngx_mail_auth_http_module.c b/src/mail/ngx_mail_auth_http_module.c
index 2e9b9f24d..8094bbc5c 100644
--- a/src/mail/ngx_mail_auth_http_module.c
+++ b/src/mail/ngx_mail_auth_http_module.c
@@ -699,7 +699,6 @@ ngx_mail_auth_http_process_headers(ngx_mail_session_t *s,
p = ngx_pnalloc(s->connection->pool, ctx->err.len);
if (p == NULL) {
- ngx_close_connection(ctx->peer.connection);
ngx_destroy_pool(ctx->pool);
ngx_mail_session_internal_server_error(s);
return;
=head1 Before Submitting
Several points are worth to consider before submitting changes:
=over
=item *
The proposed changes should work properly on a wide range of
L<supported
platforms|index>.
=item *
Try to make it clear why the suggested change is needed, and provide a use
case, if possible.
=item *
Passing your changes through the test suite is a good way to ensure
that they do not cause a regression.
The L<repository|https://github.com/nginx/nginx-tests> with
tests can be cloned with the following command:
git clone https://github.com/nginx/nginx-tests.git
=back
=head1 Submitting Changes
The proposed changes should be submitted from your fork to
L<nginx repository|https://github.com/nginx/nginx>
as a
L<pull request|https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/proposing-changes-to-your-work-with-pull-requests/creating-a-pull-request-from-a-fork>.
=head1 Website
GitHub is used to store the sources for this website.
The L<repository|https://www.github.com/nginx/nginx.org>
can be cloned with the following command:
git clone https://github.com/nginx/nginx.org.git
Documentation changes should be submitted from your fork
as a pull request.
=head1 License
Submitting changes implies granting project a permission to use it under
an appropriate L<license|../../LICENSE>.
|
